On 2020-Sep-27, Justin Pryzby wrote:
> On Fri, Sep 25, 2020 at 08:49:57AM +, Hou, Zhijie wrote:
> > In (/src/backend/replication/backup_manifest.c)
> >
> > I found the following code:
> >
> > appendStringInfoString(&buf, "\n");
> > appendStringInfoString(&buf, "\"");
>
> Good point.
On Fri, Sep 25, 2020 at 08:49:57AM +, Hou, Zhijie wrote:
> In (/src/backend/replication/backup_manifest.c)
>
> I found the following code:
>
> appendStringInfoString(&buf, "\n");
> appendStringInfoString(&buf, "\"");
Good point. There's another one:
$ git grep -E 'appendStringI
Hi
In (/src/backend/replication/backup_manifest.c)
I found the following code:
appendStringInfoString(&buf, "\n");
appendStringInfoString(&buf, "\"");
Since only one bit string is appended here,
I think it will be better to call appendStringInfoChar.
Best reagrds,
houzj
00
