Re: Asynchronous execution support for Custom Scan

2024-02-01 Thread vignesh C
On Sun, 14 Jan 2024 at 11:21, vignesh C wrote: > > On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote: > > > > > > IIUC, we already can use ctid in the where clause on the latest > > > > PostgreSQL, can't we? > > > > > > Oh, sorry, I missed the TidRangeScan. My apologies for the noise. > > > > > I

Re: Asynchronous execution support for Custom Scan

2024-01-13 Thread vignesh C
On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote: > > > > IIUC, we already can use ctid in the where clause on the latest > > > PostgreSQL, can't we? > > > > Oh, sorry, I missed the TidRangeScan. My apologies for the noise. > > > I made the ctidscan extension when we developed CustomScan API >

Re: Asynchronous execution support for Custom Scan

2022-12-01 Thread Kohei KaiGai
> > IIUC, we already can use ctid in the where clause on the latest > > PostgreSQL, can't we? > > Oh, sorry, I missed the TidRangeScan. My apologies for the noise. > I made the ctidscan extension when we developed CustomScan API towards v9.5 or v9.6, IIRC. It would make sense just an example of

Re: Asynchronous execution support for Custom Scan

2022-12-01 Thread Ronan Dunklau
> IIUC, we already can use ctid in the where clause on the latest > PostgreSQL, can't we? Oh, sorry, I missed the TidRangeScan. My apologies for the noise. Best regards, -- Ronan Dunklau

Re: Asynchronous execution support for Custom Scan

2022-12-01 Thread Kazutaka Onishi
Thank you for your comment. I've removed the tabs. > I can think of at least a few use cases where this customscan is helpful and > not merely testing code. IIUC, we already can use ctid in the where clause on the latest PostgreSQL, can't we? 2022年11月22日(火) 18:07 Ronan Dunklau : > > Le mardi

Re: Asynchronous execution support for Custom Scan

2022-11-22 Thread Ronan Dunklau
Le mardi 6 septembre 2022, 11:29:55 CET Etsuro Fujita a écrit : > On Mon, Sep 5, 2022 at 10:32 PM Kazutaka Onishi wrote: > > I'm sorry for my error on your name... > > No problem. > > > > IIUC, it uses the proposed > > > > > > APIs, but actually executes ctidscans *synchronously*, so it does

Re: Asynchronous execution support for Custom Scan

2022-09-06 Thread Etsuro Fujita
On Mon, Sep 5, 2022 at 10:32 PM Kazutaka Onishi wrote: > I'm sorry for my error on your name... No problem. > > IIUC, it uses the proposed > > APIs, but actually executes ctidscans *synchronously*, so it does not > > improve performance. Right? > Exactly. > The actual CustomScan that

Re: Asynchronous execution support for Custom Scan

2022-09-05 Thread Kazutaka Onishi
Fujita-san, I'm sorry for my error on your name... > IIUC, it uses the proposed > APIs, but actually executes ctidscans *synchronously*, so it does not > improve performance. Right? Exactly. The actual CustomScan that supports asynchronous execution will start processing in

Re: Asynchronous execution support for Custom Scan

2022-09-05 Thread Etsuro Fujita
On Fri, Sep 2, 2022 at 10:43 PM Kazutaka Onishi wrote: > The asynchronous version "ctidscan" plugin is ready. Thanks for that! I looked at the extended version quickly. IIUC, it uses the proposed APIs, but actually executes ctidscans *synchronously*, so it does not improve performance. Right?

Re: Asynchronous execution support for Custom Scan

2022-09-02 Thread Kazutaka Onishi
Hi, Fujii-san, The asynchronous version "ctidscan" plugin is ready. Please check this. https://github.com/0-kaz/ctidscan/tree/async_sample I've confirmed this works correctly by running SQL shown below. The query plan shows 2 custom scan works asynchronously. postgres=# LOAD 'ctidscan'; LOAD

Re: Asynchronous execution support for Custom Scan

2022-08-26 Thread Etsuro Fujita
Hi KaiGai-san, On Tue, Aug 23, 2022 at 6:26 PM Kohei KaiGai wrote: > I internally suggested him to expand the ctidscan module for the PoC purpose. > https://github.com/kaigai/ctidscan > > Even though it does not have asynchronous capability actually, but > suitable to ensure > API works and

Re: Asynchronous execution support for Custom Scan

2022-08-23 Thread Kohei KaiGai
I internally suggested him to expand the ctidscan module for the PoC purpose. https://github.com/kaigai/ctidscan Even though it does not have asynchronous capability actually, but suitable to ensure API works and small enough for reviewing. Best regards, 2022年8月22日(月) 17:55 Etsuro Fujita : > >

Re: Asynchronous execution support for Custom Scan

2022-08-22 Thread Etsuro Fujita
Hi Onishi-san, On Sun, Aug 14, 2022 at 12:59 PM Kazutaka Onishi wrote: > v1 patch occurs gcc warnings, I fixed it. Thanks for working on this! I'd like to review this (though, I'm not sure I can have time for it in the next commitfet), but I don't think we can review this without any example.

Re: Asynchronous execution support for Custom Scan

2022-08-13 Thread Kazutaka Onishi
v1 patch occurs gcc warnings, I fixed it. 2022年8月13日(土) 22:42 Kazutaka Onishi : > > Hello, > > I suggest supporting asynchronous execution for Custom Scan. > Since v14, PostgreSQL supports asynchronous execution for Foreign Scan. > This patch enables asynchronous execution by applying the process

Asynchronous execution support for Custom Scan

2022-08-13 Thread Kazutaka Onishi
Hello, I suggest supporting asynchronous execution for Custom Scan. Since v14, PostgreSQL supports asynchronous execution for Foreign Scan. This patch enables asynchronous execution by applying the process for Foreign Scan to Custom Scan . The patch is divided into 2 parts, source and