Hi apologies for the late reply.
> Maybe you forgot to recompile/reinstall after updating past that commit?
I did recompile it earlier but just to be sure I followed the steps again
and now its working!
Regards,
Akshat Jaimini
On Wed, Apr 3, 2024 at 12:34 AM Tom Lane wrote:
> Akshat Jaimini
Thanks to all for review, testing and commit!!!
On 2 April 2024 22:04:54 GMT+03:00, Tom Lane wrote:
>Akshat Jaimini writes:
>> The code seems to implement the feature and has good and explanatory
>> comments associated with it.
>> I believe we can go ahead with committing patch although I
Akshat Jaimini writes:
> The code seems to implement the feature and has good and explanatory comments
> associated with it.
> I believe we can go ahead with committing patch although I would request some
> senior contributors to also take a look at this patch since I am relatively
> new to
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hii,
Thanks for the updated patch. I ran make
> On 28 Mar 2024, at 10:51, Akshat Jaimini wrote:
>
> I am currently trying to review the submitted patch
Great, thank you!
> but I am not able to apply it to the master branch.
Please find attached rebased version on current HEAD. For some reason CFbot did
not notify about that rebases
Hii,
I am currently trying to review the submitted patch but I am not able to apply
it to the master branch.
Regards,
Akshat Jaimini
