Re: BufferUsage counters' values have changed

2023-09-15 Thread Karina Litskevich
Nazir, Andres, thank you both for help! On Wed, Sep 13, 2023 at 10:10 PM Andres Freund wrote: > On 2023-09-13 16:04:00 +0300, Nazir Bilal Yavuz wrote: > > local_blks_read became zero because: > > 1_ One more cache hit. It was supposed to be local_blks_read but it is > > local_blks_hit now. This

Re: BufferUsage counters' values have changed

2023-09-13 Thread Andres Freund
Hi, On 2023-09-13 11:59:39 -0700, Andres Freund wrote: > Running the attached patch through CI, planning to push after that succeeds, > unless somebody has a comment? And pushed. Thanks Karina for the report and fix! Greetings, Andres Freund

Re: BufferUsage counters' values have changed

2023-09-13 Thread Andres Freund
Hi, On 2023-09-11 09:23:59 +0300, Karina Litskevich wrote: > On Mon, Sep 11, 2023 at 9:08 AM Karina Litskevich < > litskevichkar...@gmail.com> wrote: > > > I found a bug that causes one of the differences. Wrong counter is > > incremented > > in ExtendBufferedRelLocal(). The attached patch fixes

Re: BufferUsage counters' values have changed

2023-09-13 Thread Andres Freund
Hi, On 2023-09-13 16:04:00 +0300, Nazir Bilal Yavuz wrote: > On Mon, 11 Sept 2023 at 14:28, Karina Litskevich > wrote: > > > > Hi hackers, > > > > I noticed that BufferUsage counters' values are strangely different for the > > same queries on REL_15_STABLE and REL_16_STABLE. For example, I run >

Re: BufferUsage counters' values have changed

2023-09-13 Thread Nazir Bilal Yavuz
Hi, On Mon, 11 Sept 2023 at 14:28, Karina Litskevich wrote: > > Hi hackers, > > I noticed that BufferUsage counters' values are strangely different for the > same queries on REL_15_STABLE and REL_16_STABLE. For example, I run > > CREATE EXTENSION pg_stat_statements; > CREATE TEMP TABLE test(b int

Re: BufferUsage counters' values have changed

2023-09-10 Thread Karina Litskevich
On Mon, Sep 11, 2023 at 9:08 AM Karina Litskevich < litskevichkar...@gmail.com> wrote: > I found a bug that causes one of the differences. Wrong counter is > incremented > in ExtendBufferedRelLocal(). The attached patch fixes it and should be > applied > to REL_16_STABLE and master. > I've forgo

BufferUsage counters' values have changed

2023-09-10 Thread Karina Litskevich
Hi hackers, I noticed that BufferUsage counters' values are strangely different for the same queries on REL_15_STABLE and REL_16_STABLE. For example, I run CREATE EXTENSION pg_stat_statements; CREATE TEMP TABLE test(b int); INSERT INTO test(b) SELECT generate_series(1,1000); SELECT query, local_b