Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2022-01-03 Thread Tom Lane
Aleksander Alekseev writes: > The cfbot seems to be happy with the updated patch. > The new status of this patch is: Ready for Committer Pushed. regards, tom lane

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-09-24 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed The cfbot seems to be happy with the updated patch. The new

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-09-24 Thread Aleksander Alekseev
Hi David, > Please find attached the next revision :) The patch didn't apply and couldn't pass cfbot [1]. The (hopefully) corrected patch is attached. Other than that it looks OK to me but let's see what cfbot will tell. [1]: http://cfbot.cputube.org/patch_34_3113.log -- Best regards, Aleksand

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-09-14 Thread David Fetter
On Fri, Sep 03, 2021 at 08:27:55PM +0200, Daniel Gustafsson wrote: > > On 19 May 2021, at 09:53, Michael Paquier wrote: > > > > On Tue, Apr 27, 2021 at 12:58:52PM +0300, Aleksander Alekseev wrote: > >> I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here > >> is an alternative ve

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-09-03 Thread Daniel Gustafsson
> On 19 May 2021, at 09:53, Michael Paquier wrote: > > On Tue, Apr 27, 2021 at 12:58:52PM +0300, Aleksander Alekseev wrote: >> I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here >> is an alternative version of the patch that fixes this as well. Not >> sure if this should be in

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-05-19 Thread Michael Paquier
On Tue, Apr 27, 2021 at 12:58:52PM +0300, Aleksander Alekseev wrote: > I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here > is an alternative version of the patch that fixes this as well. Not > sure if this should be in the same commit though. - /* If we have ALTER TABLE DROP

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-04-27 Thread David Fetter
On Tue, Apr 27, 2021 at 12:33:25PM +0300, Aleksander Alekseev wrote: > Hi David, > > > I noticed that $subject completes with already valid constraints, > > please find attached a patch that fixes it. I noticed that there are > > other places constraints can be validated, but didn't check whether

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-04-27 Thread Aleksander Alekseev
Hi hackers, > Otherwise the patch passes all the tests and works as expected I've noticed there is no tab completion for ALTER TABLE xxx ADD. Here is an alternative version of the patch that fixes this as well. Not sure if this should be in the same commit though. -- Best regards, Aleksander Al

Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-04-27 Thread Aleksander Alekseev
Hi David, > I noticed that $subject completes with already valid constraints, > please find attached a patch that fixes it. I noticed that there are > other places constraints can be validated, but didn't check whether > similar bugs exist there yet. There was a typo in the patch ("... and and no

Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ...

2021-04-26 Thread David Fetter
Folks, I noticed that $subject completes with already valid constraints, please find attached a patch that fixes it. I noticed that there are other places constraints can be validated, but didn't check whether similar bugs exist there yet. Best, David. -- David Fetter http://fetter.org/ Phone: