Re: CLUSTER sort on abbreviated expressions is broken

2022-04-20 Thread Thomas Munro
On Thu, Apr 21, 2022 at 12:18 PM Peter Geoghegan wrote: > On Tue, Apr 12, 2022 at 11:01 AM Peter Geoghegan wrote: > > Attached patch fixes the issue, and includes the test case that you posted. > > Pushed a similar patch just now. Backpatched to all supported branches. Thanks.

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-20 Thread Peter Geoghegan
On Tue, Apr 12, 2022 at 11:01 AM Peter Geoghegan wrote: > Attached patch fixes the issue, and includes the test case that you posted. Pushed a similar patch just now. Backpatched to all supported branches. -- Peter Geoghegan

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-12 Thread Peter Geoghegan
On Sun, Apr 3, 2022 at 4:34 PM Thomas Munro wrote: > I probably should have made it clearer in the commit message, > cc58eecc5 doesn't fix this problem in the master branch. It only > fixes the code that incorrectly assumed that datum1 was always > available. Attached patch fixes the issue, and

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-03 Thread Thomas Munro
On Mon, Apr 4, 2022 at 11:12 AM Peter Geoghegan wrote: > We will need a backpatchable fix, since Thomas' recent fix (commit > cc58eecc5d75a9329a6d49a25a6499aea7ee6fd6) only targeted the master > branch. I probably should have made it clearer in the commit message, cc58eecc5 doesn't fix this

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-03 Thread Peter Geoghegan
On Sun, Apr 3, 2022 at 1:22 AM John Naylor wrote: > I can confirm the problem on v10 as well. We will need a backpatchable fix, since Thomas' recent fix (commit cc58eecc5d75a9329a6d49a25a6499aea7ee6fd6) only targeted the master branch. If we really needed the performance advantage of

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-03 Thread Thomas Munro
On Sun, Apr 3, 2022 at 8:22 PM John Naylor wrote: > On Sun, Apr 3, 2022 at 11:05 AM Thomas Munro wrote: > > Independently of a problem with a recent commit, it seems that > > $SUBJECT in all releases (well, I only tested as far back as 11). > > I can confirm the problem on v10 as well. Thanks

Re: CLUSTER sort on abbreviated expressions is broken

2022-04-03 Thread John Naylor
On Sun, Apr 3, 2022 at 11:05 AM Thomas Munro wrote: > > Hi, > > Independently of a problem with a recent commit, it seems that > $SUBJECT in all releases (well, I only tested as far back as 11). I can confirm the problem on v10 as well. -- John Naylor EDB: http://www.enterprisedb.com

CLUSTER sort on abbreviated expressions is broken

2022-04-02 Thread Thomas Munro
Hi, Independently of a problem with a recent commit, it seems that $SUBJECT in all releases (well, I only tested as far back as 11). I attach an addition to the tests to show this, but here's a stand-alone repro: DROP TABLE IF EXISTS clstr_expression; CREATE TABLE clstr_expression(id serial