Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

On Tue, Nov 18, 2025 at 5:27 PM Chao Li wrote: > Thanks for addressing the comments. V5 looks good to me. Thanks both for the patch and review! -where all_publication_object is one of: +where table_spec is: + +[ ONLY ] table_name [ * ] [ ( column_name [, ... ] ) ] [ WHERE ( expressio

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

> On Nov 18, 2025, at 13:31, Peter Smith wrote: > > On Mon, Nov 17, 2025 at 5:49 PM Chao Li wrote: > ... >>> #1. >>> My original change, to fix the [, ...] grouping to remove ambiguity. >>> >>> #2 >>> Now renames "all_publication_object" to "publication_all_objects". >>> This is a simple nam

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

On Mon, Nov 17, 2025 at 5:49 PM Chao Li wrote: ... > > #1. > > My original change, to fix the [, ...] grouping to remove ambiguity. > > > > #2 > > Now renames "all_publication_object" to "publication_all_objects". > > This is a simple name change that does not affect anything. I felt > > everythin

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

> On Nov 17, 2025, at 14:48, Chao Li wrote: > >> #2 >> Now renames "all_publication_object" to "publication_all_objects". >> This is a simple name change that does not affect anything. I felt >> everything ought to have the prefix of the object it belongs to (e.g. >> "publication_name", "publi

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

> On Nov 17, 2025, at 08:30, Peter Smith wrote: > > On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote: >> >> >> >>> On Nov 14, 2025, at 15:47, Fujii Masao wrote: >>> >>> On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: A rebase was needed. Here is patch v3. >>> >>> Thanks for

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote: > > > > > On Nov 14, 2025, at 15:47, Fujii Masao wrote: > > > > On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: > >> > >> A rebase was needed. Here is patch v3. > > > > Thanks for the patch! LGTM. > > > > For example, in the CREATE PUBLICATION s

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

> On Nov 14, 2025, at 15:47, Fujii Masao wrote: > > On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: >> >> A rebase was needed. Here is patch v3. > > Thanks for the patch! LGTM. > > For example, in the CREATE PUBLICATION synopsis, the part that can be > repeated is "[ ONLY ] table_name

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote: > > A rebase was needed. Here is patch v3. Thanks for the patch! LGTM. For example, in the CREATE PUBLICATION synopsis, the part that can be repeated is "[ ONLY ] table_name ... [ WHERE ( expression ) ]" not just the WHERE clause, so using curl

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

A rebase was needed. Here is patch v3. == Kind Regards, Peter Smith. Fujitsu Australia v3-0001-Add-curly-brackets-before-ellipsis.patch Description: Binary data

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

A rebase was needed. Here is patch v2. == Kind Regards, Peter Smith. Fujitsu Australia v2-0001-Add-curly-brackets-before-ellipsis.patch Description: Binary data

Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

Added a CF entry [1] for this. == [1] https://commitfest.postgresql.org/patch/6062/ Kind Regards, Peter Smith. Fujitsu Australia

CREATE/ALTER PUBLICATION improvements for syntax synopsis

During some recent reviews in this area, I noticed both CREATE/ALTER PUBLICATION synopses say: -- where publication_object is one of: TABLE [ ONLY ] table_name [ * ] [ ( column_name [, ... ] ) ] [ WHERE ( expression ) ] [, ... ] TABLES IN SCHEMA { schema_name | CURRENT_SCHEMA } [,