Re: Calling PGReserveSemaphores() from CreateOrAttachShmemStructs

2025-08-26 Thread Ashutosh Bapat
Hi Thomas, On Mon, Aug 25, 2025 at 3:11 PM Thomas Munro wrote: > > On Mon, Aug 25, 2025 at 9:10 PM Ashutosh Bapat > wrote: > > Is this change correct? Was there any reason to leave it like that in > > e25626677f8076eb3ce94586136c5464ee154381? Or was it just something > > that didn't fit in that

Re: Calling PGReserveSemaphores() from CreateOrAttachShmemStructs

2025-08-25 Thread Thomas Munro
On Mon, Aug 25, 2025 at 9:10 PM Ashutosh Bapat wrote: > Is this change correct? Was there any reason to leave it like that in > e25626677f8076eb3ce94586136c5464ee154381? Or was it just something > that didn't fit in that commit? We/I just missed that opportunity when ripping that stuff out. It s

Calling PGReserveSemaphores() from CreateOrAttachShmemStructs

2025-08-25 Thread Ashutosh Bapat
Hi, PGReserveSemaphores() allocates shared memory space for semaphores. I was expecting it to be part of CreateOrAttachShmemStructs() and not be directly called from CreateSharedMemoryAndSemaphores(). But before e25626677f8076eb3ce94586136c5464ee154381, it was required to be called before Spinlock