Re: Cleaning up perl code

2024-05-23 Thread Michael Paquier
On Tue, May 21, 2024 at 02:33:16PM +0900, Michael Paquier wrote: > Nice catches from both of you. The two ones in > generate-wait_event_types.pl are caused by me, actually. > > Not sure about the changes in the errcodes scripts, though. The > current state of thing can be also useful when it

Re: Cleaning up perl code

2024-05-20 Thread Michael Paquier
On Tue, May 21, 2024 at 06:00:00AM +0300, Alexander Lakhin wrote: > I reviewed my collection of unica I gathered for several months, but had > found some of them too minor/requiring more analysis. > Then I added more with perlcritic's policy UnusedVariables, and also > checked for unused subs with

Re: Cleaning up perl code

2024-05-20 Thread Alexander Lakhin
Hello Dagfinn, Thank you for paying attention to it and improving the possible fix! 20.05.2024 23:39, Dagfinn Ilmari Mannsåker wrote: Nice cleanup! Did you use some static analysis tool, or did look for them manually? I reviewed my collection of unica I gathered for several months, but had

Re: Cleaning up perl code

2024-05-20 Thread Dagfinn Ilmari Mannsåker
Alexander Lakhin writes: > Hello hackers, > > Please look at a bunch of unused variables and a couple of other defects > I found in the perl code, maybe you'll find them worth fixing: Nice cleanup! Did you use some static analysis tool, or did look for them manually? If I add

Cleaning up perl code

2024-05-20 Thread Alexander Lakhin
Hello hackers, Please look at a bunch of unused variables and a couple of other defects I found in the perl code, maybe you'll find them worth fixing: contrib/amcheck/t/001_verify_heapam.pl $result # unused since introduction in 866e24d47 unused sub: get_toast_for # not used since 860593ec3