On Sun, 2025-06-29 at 12:43 +0200, Peter Eisentraut wrote:
> I wish we could take this further and also run the "ctype is c" case
> through the method table. Right now, there are still a bunch of
> open-coded special cases all over the place, which could be unified.
> I
> guess this isn't any
On 12.06.25 07:49, Jeff Davis wrote:
On Fri, 2025-02-07 at 11:19 -0800, Jeff Davis wrote:
Attached v15. Just a rebase.
Attached v16.
* commit this on the grounds that it's a desirable code improvement
and
the worst-case regression isn't a major concern; or
I plan to commit this soon after
On Fri, 2025-02-07 at 11:19 -0800, Jeff Davis wrote:
>
> Attached v15. Just a rebase.
Attached v16.
> * commit this on the grounds that it's a desirable code improvement
> and
> the worst-case regression isn't a major concern; or
I plan to commit this soon after branching. There's a general con
> I'm still inlined to think the method table is a good thing to do:
>
> (a) The performance cases I tried seem implausibly bad -- running
> character classification patterns over large fields consisting only
> of
> codepoints over U+07FF.
>
> (b) The method tables seem like a better code organiz
On Wed, 2025-01-15 at 12:42 -0800, Jeff Davis wrote:
> > Here's v12 after committing a few of the earlier patches.
And here's v14, just a rebase.
> I collected some performance numbers for a worst case on UTF8.
I'm still inlined to think the method table is a good thing to do:
(a) The performan
On Thu, 2025-01-09 at 16:19 -0800, Jeff Davis wrote:
> On Mon, 2024-12-02 at 23:58 -0800, Jeff Davis wrote:
> > On Mon, 2024-12-02 at 16:39 +0100, Andreas Karlsson wrote:
> > > I feel your first patch in the series is something you can just
> > > commit.
> >
> > Done.
> >
> > I combined your pat
On Mon, 2024-12-02 at 23:58 -0800, Jeff Davis wrote:
> On Mon, 2024-12-02 at 16:39 +0100, Andreas Karlsson wrote:
> > I feel your first patch in the series is something you can just
> > commit.
>
> Done.
>
> I combined your patches and mine into the attached v10 series.
Here's v12 after committ
On 12/5/24 1:21 AM, Jeff Davis wrote:
= v9-0003-Move-code-for-collation-version-into-provider-spe.patch
Moves some code from pg_collate.c into provider specific files.
I agree with the general idea, but it seems we are accumulating a lot
of provider-specific functions. Should we define a pro
On Mon, 2024-12-02 at 16:39 +0100, Andreas Karlsson wrote:
> My patches:
>
> = v9-0002-Move-check-for-ucol_strcollUTF8-to-pg_locale_icu..patch
Committed.
> = v9-0003-Move-code-for-collation-version-into-provider-spe.patch
>
> Moves some code from pg_collate.c into provider specific files.
I ag
On Fri, 2024-11-01 at 14:08 +0100, Andreas Karlsson wrote:
> > Agreed -- a lot of work has gone into optimizing the regex code,
> > and we
> > don't want a perf regression there. But I'm also not sure exactly
> > which
> > kinds of tests I should be running for that.
>
> I think we should at least
On 10/26/24 12:42 AM, Jeff Davis wrote:
On Thu, 2024-10-24 at 10:05 +0200, Andreas Karlsson wrote:
Why is there no pg_locale_builtin.c?
Just that it would be a fairly small file, but I'm fine with doing
that.
I think adding such a small file would make life easier for people new
to the coll
On Thu, 2024-10-24 at 10:05 +0200, Andreas Karlsson wrote:
> Why is there no pg_locale_builtin.c?
Just that it would be a fairly small file, but I'm fine with doing
that.
> I think adding an assert to create_pg_locale() which enforces valid
> there is always a combination of ctype_is_c and casem
On Fri, 2024-10-04 at 15:24 +0200, Andreas Karlsson wrote:
> Great! I had been planning to do this myself so great to see that you
> already did it before me. Will take a look at this work later.
Great! We'll need to test whether there are any regressions in the
regex & pattern matching code due t
On 9/27/24 12:30 AM, Jeff Davis wrote:
The attached patch series refactors the collation and ctype behavior
into method tables, and provides a way to hook the creation of a
pg_locale_t so that an extension can create any kind of method table it
wants.
Great! I had been planning to do this mysel
14 matches
Mail list logo
