Re: Comment fix of config_default.pl

2019-07-16 Thread Kyotaro Horiguchi
At Sat, 13 Jul 2019 16:53:45 +0900, Michael Paquier wrote in <20190713075345.gc2...@paquier.xyz> > On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote: > > I would also patch GetFakeConfigure in Solution.pm (no need to send a > > new patch), and I thought that you'd actually do the

Re: Comment fix of config_default.pl

2019-07-13 Thread Michael Paquier
On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote: > I would also patch GetFakeConfigure in Solution.pm (no need to send a > new patch), and I thought that you'd actually do the change. What do > you think? OK, applied as I have been able to look at it again, and after fixing the

Re: Comment fix of config_default.pl

2019-07-12 Thread Michael Paquier
On Fri, Jul 12, 2019 at 03:34:11PM +0900, Kyotaro Horiguchi wrote: > At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier > wrote in <20190712040113.gd2...@paquier.xyz> >> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to >> replace it with --with-uuid=? That would be a bit

Re: Comment fix of config_default.pl

2019-07-12 Thread Kyotaro Horiguchi
Thanks. At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier wrote in <20190712040113.gd2...@paquier.xyz> > On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > > In src/tools/msvc/config_default.pl, parameter "perl" requires a > > path string, not a bool differently from that of

Re: Comment fix of config_default.pl

2019-07-11 Thread Michael Paquier
On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > In src/tools/msvc/config_default.pl, parameter "perl" requires a > path string, not a bool differently from that of configure > script. --with-python has the same characteristics and the > comment is suggesting that. > > We need

Comment fix of config_default.pl

2019-07-11 Thread Kyotaro Horiguchi
Hello. In src/tools/msvc/config_default.pl, peremeter "perl" requires a path string, not a bool differently from that of configure script. --with-python has the same characteristics and the comment is suggesting that. We need to fix --with-perl and --with-uuid the same way. regards. --