Re: Comment simplehash/dynahash trade-offs

2020-08-02 Thread Thomas Munro
On Mon, Aug 3, 2020 at 11:42 AM David Rowley wrote: > On Mon, 3 Aug 2020 at 11:36, David Rowley wrote: > > So, with the current users, we'd stand to lose more than we'd gain > > from doing it that way. > > FWIW, I'd be ok with just: > > - * The element type is required to contain a "uint32

Re: Comment simplehash/dynahash trade-offs

2020-08-02 Thread David Rowley
On Mon, 3 Aug 2020 at 11:36, David Rowley wrote: > So, with the current users, we'd stand to lose more than we'd gain > from doing it that way. FWIW, I'd be ok with just: - * The element type is required to contain a "uint32 status" member. + * The element type is required to contain

Re: Comment simplehash/dynahash trade-offs

2020-08-02 Thread David Rowley
On Mon, 3 Aug 2020 at 11:10, Thomas Munro wrote: > I think you can probably go further, though, and make it require no > storage at all by making it optionally "intrusive", by using a special > value in an existing member, and supplying an expression to set and > test for that value. For example,

Re: Comment simplehash/dynahash trade-offs

2020-08-02 Thread Thomas Munro
On Sun, Aug 2, 2020 at 1:54 PM David Rowley wrote: > On Sun, 2 Aug 2020 at 11:16, David Rowley wrote: > > Maybe it would be better just to get rid of the enum and just #define > > the values. It seems unlikely that we're every going to need many more > > states than what are there already, let al

Re: Comment simplehash/dynahash trade-offs

2020-08-01 Thread David Rowley
On Sun, 2 Aug 2020 at 11:16, David Rowley wrote: > Maybe it would be better just to get rid of the enum and just #define > the values. It seems unlikely that we're every going to need many more > states than what are there already, let along more than, say 127 of > them. It does look like manifest

Re: Comment simplehash/dynahash trade-offs

2020-08-01 Thread David Rowley
On Sat, 1 Aug 2020 at 12:17, Thomas Munro wrote: > > On Sat, Aug 1, 2020 at 7:22 AM James Coleman wrote: > > [v2 patch set] > > I ran it through pgindent which insisted on adding some newlines, I > manually replaced some spaces with tabs to match nearby lines, I added > some asterisks in your exa

Re: Comment simplehash/dynahash trade-offs

2020-08-01 Thread James Coleman
On Fri, Jul 31, 2020 at 8:17 PM Thomas Munro wrote: > > On Sat, Aug 1, 2020 at 7:22 AM James Coleman wrote: > > [v2 patch set] > > I ran it through pgindent which insisted on adding some newlines, I > manually replaced some spaces with tabs to match nearby lines, I added > some asterisks in your

Re: Comment simplehash/dynahash trade-offs

2020-07-31 Thread Thomas Munro
On Sat, Aug 1, 2020 at 7:22 AM James Coleman wrote: > [v2 patch set] I ran it through pgindent which insisted on adding some newlines, I manually replaced some spaces with tabs to match nearby lines, I added some asterisks in your example function prototypes where is returned because they seemed

Re: Comment simplehash/dynahash trade-offs

2020-07-31 Thread James Coleman
On Mon, Jul 20, 2020 at 1:29 AM Thomas Munro wrote: > > On Fri, May 1, 2020 at 1:53 PM James Coleman wrote: > > In another thread [1] I'd mused that "there might be some value in a > > README or comments > > addition that would be a guide to what the various hash > > implementations are useful fo

Re: Comment simplehash/dynahash trade-offs

2020-07-19 Thread Thomas Munro
On Fri, May 1, 2020 at 1:53 PM James Coleman wrote: > In another thread [1] I'd mused that "there might be some value in a > README or comments > addition that would be a guide to what the various hash > implementations are useful for...so that we have something to make the > code base a bit more

Comment simplehash/dynahash trade-offs

2020-04-30 Thread James Coleman
In another thread [1] I'd mused that "there might be some value in a README or comments addition that would be a guide to what the various hash implementations are useful for...so that we have something to make the code base a bit more discoverable." I'd solicited feedback from Andres (as the auth