Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE

2020-08-17 Thread Heikki Linnakangas
On 17/08/2020 10:00, Michael Paquier wrote: On Sat, Aug 15, 2020 at 11:05:43AM +0530, Amit Kapila wrote: On Fri, Aug 14, 2020 at 2:17 PM Heikki Linnakangas wrote: It's always been like that, but I am not going backport, for fear of breaking existing applications. If a program reads the WAL, an

Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE

2020-08-17 Thread Michael Paquier
On Sat, Aug 15, 2020 at 11:05:43AM +0530, Amit Kapila wrote: > On Fri, Aug 14, 2020 at 2:17 PM Heikki Linnakangas wrote: >> It's always been like that, but I am not going backport, for fear of >> breaking existing applications. If a program reads the WAL, and would >> actually need to do something

Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE

2020-08-14 Thread Amit Kapila
On Fri, Aug 14, 2020 at 2:17 PM Heikki Linnakangas wrote: > > While hacking on pg_rewind, I noticed that commit and abort WAL records > are never marked with the XLR_SPECIAL_REL_UPDATE flag. But if the record > contains "dropped relfilenodes", surely it should be? > Right. > It's harmless as far

Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE

2020-08-14 Thread Heikki Linnakangas
While hacking on pg_rewind, I noticed that commit and abort WAL records are never marked with the XLR_SPECIAL_REL_UPDATE flag. But if the record contains "dropped relfilenodes", surely it should be? It's harmless as far as the backend and all the programs in PostgreSQL repository are concerned