Re: Compiler warnings with MinGW

2019-09-17 Thread Michael Paquier
On Tue, Sep 17, 2019 at 12:00:39PM +0200, Peter Eisentraut wrote: > committed Thanks, Peter. -- Michael signature.asc Description: PGP signature

Re: Compiler warnings with MinGW

2019-09-17 Thread Peter Eisentraut
On 2019-09-09 14:24, Magnus Hagander wrote: > On Sat, Sep 7, 2019 at 4:58 AM Michael Paquier > wrote: > > On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote: > > I'm not sure exactly what the upstream of mingw is these days, but I > > think th

Re: Compiler warnings with MinGW

2019-09-09 Thread Magnus Hagander
On Sat, Sep 7, 2019 at 4:58 AM Michael Paquier wrote: > On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote: > > I'm not sure exactly what the upstream of mingw is these days, but I > > think the original issue that led to 811be893 has long been fixed [0], > > and the other stuff in

Re: Compiler warnings with MinGW

2019-09-06 Thread Michael Paquier
On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote: > I'm not sure exactly what the upstream of mingw is these days, but I > think the original issue that led to 811be893 has long been fixed [0], > and the other stuff in mingwcompat.c is also no longer relevant [1]. I > think mingwco

Re: Compiler warnings with MinGW

2019-09-06 Thread Peter Eisentraut
On 2019-07-19 14:41, Andrew Dunstan wrote: > On 7/19/19 1:08 AM, Michael Paquier wrote: >> Just browsing through the logs of the buildfarm, I have noticed that >> some buildfarm animals complain with warnings (jacana uses MinGW): >> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=jaca

Re: Compiler warnings with MinGW

2019-07-21 Thread Michael Paquier
On Sat, Jul 20, 2019 at 06:19:34PM +0900, Michael Paquier wrote: > Just wanted to double-check something. We usually don't bother > back-patching warning fixes like this one, right? I have double-checked the thing, and applied it only on HEAD as we have that for some time (since 9.1 actually and

Re: Compiler warnings with MinGW

2019-07-20 Thread Michael Paquier
On Fri, Jul 19, 2019 at 08:41:28AM -0400, Andrew Dunstan wrote: > On 7/19/19 1:08 AM, Michael Paquier wrote: >> The second one is rather obvious to fix, because we don't care about >> the file mode on Windows, so the attached should do the work. I am >> actually surprised that the Visual Studio co

Re: Compiler warnings with MinGW

2019-07-19 Thread Andrew Dunstan
On 7/19/19 1:08 AM, Michael Paquier wrote: > Hi all, > > Just browsing through the logs of the buildfarm, I have noticed that > some buildfarm animals complain with warnings (jacana uses MinGW): > https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=jacana&dt=2019-07-19%2001%3A45%3A28&st

Compiler warnings with MinGW

2019-07-18 Thread Michael Paquier
Hi all, Just browsing through the logs of the buildfarm, I have noticed that some buildfarm animals complain with warnings (jacana uses MinGW): https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=jacana&dt=2019-07-19%2001%3A45%3A28&stg=make There are two of them: c:/mingw/msys/1.0/home/