Re: Confused about TransactionIdSetTreeStatus

2022-10-25 Thread Heikki Linnakangas
On 25/10/2022 18:09, Japin Li wrote: On Tue, 25 Oct 2022 at 22:46, Heikki Linnakangas wrote: On 25/10/2022 12:02, Japin Li wrote: However, the code marks the main transaction and subtransactions directly to the committed. Hmm, yeah, step 2 in this example doesn't match reality. We actually

Re: Confused about TransactionIdSetTreeStatus

2022-10-25 Thread Japin Li
On Tue, 25 Oct 2022 at 22:46, Heikki Linnakangas wrote: > On 25/10/2022 12:02, Japin Li wrote: >> However, the code marks the main transaction and subtransactions directly >> to the committed. > > Hmm, yeah, step 2 in this example doesn't match reality. We actually > set t and t1 directly as comm

Re: Confused about TransactionIdSetTreeStatus

2022-10-25 Thread Heikki Linnakangas
On 25/10/2022 12:02, Japin Li wrote: I'm a bit confused about TransactionIdSetTreeStatus, the comment says if subtransactions cross multiple CLOG pages, it will mark the subxids, that are on the same page as the main transaction, as sub-committed, and then set main transactio

Confused about TransactionIdSetTreeStatus

2022-10-25 Thread Japin Li
Hi, hackers I'm a bit confused about TransactionIdSetTreeStatus, the comment says if subtransactions cross multiple CLOG pages, it will mark the subxids, that are on the same page as the main transaction, as sub-committed, and then set main transaction and subtransactions to committed (s