On 24.05.24 16:39, Tom Lane wrote:
Maybe not three settings, but a single setting, with multiple values, like
debug_io_direct?
Yeah, good idea. Let's get some more feedback on this before I code up
a complicated list parser.
Kinda doubt it's worth the trouble, either to code the GUC support or
Peter Eisentraut writes:
> Ok, I have an improved plan. I'm wrapping all the code related to this
> in #ifdef DEBUG_NODE_TESTS_ENABLED. This in turn is defined in
> assert-enabled builds, or if you define it explicitly, or if you define
> one of the legacy individual symbols. That way you ge
ssion
coverage still needs to be maintained by hand, so it's more often
valuable to have it checked automatically.
From 80f35c90e3414dabd879e8832ce1b89c685e5de5 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 24 May 2024 11:42:02 +0200
Subject: [PATCH v2] Convert node test
Hi,
On 2024-05-20 09:28:39 +0200, Peter Eisentraut wrote:
> - Performance? Looking for example at pg_parse_query() and its siblings,
> they also check for other debugging settings like log_parser_stats in the
> main code path, so it doesn't seem to be a concern.
I don't think we can conclude tha
Em ter., 21 de mai. de 2024 às 09:25, Peter Eisentraut
escreveu:
> On 20.05.24 15:59, Tom Lane wrote:
> > Peter Eisentraut writes:
> >> This patch converts the compile-time settings
> >> COPY_PARSE_PLAN_TREES
> >> WRITE_READ_PARSE_PLAN_TREES
> >> RAW_EXPRESSION_COVERAGE_TEST
>
On 20.05.24 15:59, Tom Lane wrote:
Peter Eisentraut writes:
This patch converts the compile-time settings
COPY_PARSE_PLAN_TREES
WRITE_READ_PARSE_PLAN_TREES
RAW_EXPRESSION_COVERAGE_TEST
into run-time parameters
debug_copy_parse_plan_trees
debug_write_read_pars
Peter Eisentraut writes:
> This patch converts the compile-time settings
> COPY_PARSE_PLAN_TREES
> WRITE_READ_PARSE_PLAN_TREES
> RAW_EXPRESSION_COVERAGE_TEST
> into run-time parameters
> debug_copy_parse_plan_trees
> debug_write_read_parse_plan_trees
> debug_raw_exp
Em seg., 20 de mai. de 2024 às 04:28, Peter Eisentraut
escreveu:
> This patch converts the compile-time settings
>
> COPY_PARSE_PLAN_TREES
> WRITE_READ_PARSE_PLAN_TREES
> RAW_EXPRESSION_COVERAGE_TEST
>
> into run-time parameters
>
> debug_copy_parse_plan_trees
> debug_wri
PGC_SUSET?
Another thought: Do we really need three separate settings?
From 568c620eb97f82aa8eab850cb3ce703c5c94a912 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Mon, 20 May 2024 09:13:23 +0200
Subject: [PATCH v1] Convert node test compile-time settings into run-time
parameters
Thi
