Re: CopyFrom() has become way too complicated

2018-10-15 Thread Corey Huinker
> > I think the code needs to be split up so that CopyFrom() in the loop > body calls CopyFromOneTuple(), which then also splits out the tuple > routing into its own CopyFromOneTupleRoute() function (that's 200 LOC on > its own...). I suspect it'd also be good to refactor the > partition-change

CopyFrom() has become way too complicated

2018-10-12 Thread Andres Freund
Hi, I've had to whack CopyFrom() around a couple times due to the pluggable storage patch, and I found that after commit 0d5f05cde011512e605bb2688d9b1fbb5b3ae152 Author: Peter Eisentraut Date: 2018-08-01 10:23:09 +0200 Allow multi-inserts during COPY into a partitioned table and also the