Re: Correct comment in RemoveNonParentXlogFiles()

2022-08-04 Thread Ashutosh Sharma
On Thu, Aug 4, 2022 at 11:30 AM Kyotaro Horiguchi wrote: > At Wed, 3 Aug 2022 18:16:33 +0530, Ashutosh Sharma > wrote in > > Following comment in RemoveNonParentXlogFiles() says that we are trying > to > > remove any WAL file whose segment number is >= the segment number of the > > first WAL

Re: Correct comment in RemoveNonParentXlogFiles()

2022-08-04 Thread Kyotaro Horiguchi
At Thu, 04 Aug 2022 15:00:06 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 3 Aug 2022 18:16:33 +0530, Ashutosh Sharma > wrote in > > Following comment in RemoveNonParentXlogFiles() says that we are trying to > > remove any WAL file whose segment number is >= the segment number of the > >

Re: Correct comment in RemoveNonParentXlogFiles()

2022-08-04 Thread Kyotaro Horiguchi
At Wed, 3 Aug 2022 18:16:33 +0530, Ashutosh Sharma wrote in > Following comment in RemoveNonParentXlogFiles() says that we are trying to > remove any WAL file whose segment number is >= the segment number of the > first WAL file on the new timeline. However, looking at the code, I can say >

Correct comment in RemoveNonParentXlogFiles()

2022-08-03 Thread Ashutosh Sharma
HI All, Following comment in RemoveNonParentXlogFiles() says that we are trying to remove any WAL file whose segment number is >= the segment number of the first WAL file on the new timeline. However, looking at the code, I can say that we are trying to remove the WAL files from the previous