Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-06 Thread Robert Haas
On Mon, Feb 5, 2018 at 11:02 PM, Ashutosh Bapat wrote: > The comment says why it checks both bounds and part_scheme, but it > doesn't explain why we check nparts, part_rels etc. My patch had that > explanation. Hmm, well, I couldn't understand it from your

Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-05 Thread Ashutosh Bapat
On Tue, Feb 6, 2018 at 4:04 AM, Robert Haas wrote: > On Mon, Feb 5, 2018 at 4:46 AM, Ashutosh Bapat > wrote: >> Here's patch taking that approach. > > I rewrote the comment in relation.h like this, which I think is more clear: > > /* > *

Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-05 Thread Robert Haas
On Mon, Feb 5, 2018 at 4:46 AM, Ashutosh Bapat wrote: > Here's patch taking that approach. I rewrote the comment in relation.h like this, which I think is more clear: /* * Is given relation partitioned? * - * A join between two partitioned relations with

Crash in partition-wise join involving dummy partitioned relation

2018-02-05 Thread Ashutosh Bapat
Hi, I noticed a crash in partition-wise involving dummy partitioned tables. Here's simple testcase CREATE TABLE prt1 (a int, b int, c varchar) PARTITION BY RANGE(a); CREATE TABLE prt1_p1 PARTITION OF prt1 FOR VALUES FROM (0) TO (250); CREATE TABLE prt1_p3 PARTITION OF prt1 FOR VALUES FROM (500)