Re: Detailed release notes

On Tue, Oct 15, 2024 at 02:23:15PM -0400, Bruce Momjian wrote: > On Tue, Oct 15, 2024 at 02:21:31PM -0400, Tom Lane wrote: >> Bruce Momjian writes: >> > On Tue, Oct 15, 2024 at 11:04:50AM -0700, Jacob Champion wrote: >> >> Maybe plus-minus (±), to represent the diff? >> >> > Uh, that might make s

Re: Detailed release notes

On Tue, Oct 15, 2024 at 02:21:31PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Oct 15, 2024 at 11:04:50AM -0700, Jacob Champion wrote: > >> Maybe plus-minus (±), to represent the diff? > > > Uh, that might make sense to people who vie diffs often, but not the > > average reader of

Re: Detailed release notes

Bruce Momjian writes: > On Tue, Oct 15, 2024 at 11:04:50AM -0700, Jacob Champion wrote: >> Maybe plus-minus (±), to represent the diff? > Uh, that might make sense to people who vie diffs often, but not the > average reader of the document. Well, the § symbol hasn't got that much mnemonic value

Re: Detailed release notes

On Tue, Oct 15, 2024 at 11:04:50AM -0700, Jacob Champion wrote: > On Tue, Oct 15, 2024 at 11:01 AM Tom Lane wrote: > > > > Sticking to LATIN-1 is not such a bad idea from this perspective. > > Maybe plus-minus (±), to represent the diff? Uh, that might make sense to people who vie diffs often, b

Re: Detailed release notes

On Tue, Oct 15, 2024 at 11:01 AM Tom Lane wrote: > > Sticking to LATIN-1 is not such a bad idea from this perspective. Maybe plus-minus (±), to represent the diff? --Jacob

Re: Detailed release notes

On Tue, Oct 15, 2024 at 02:01:05PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I thought we were restricted to Latin-1 characters, because those are > > the only characters that the PDF output supports. > > > However, since we decided not to have the commit detail links in the PDF > > outp

Re: Detailed release notes

Bruce Momjian writes: > I thought we were restricted to Latin-1 characters, because those are > the only characters that the PDF output supports. > However, since we decided not to have the commit detail links in the PDF > output, it is actually safe to use _any_ Unicode character as the commit >

Re: Detailed release notes

On Tue, Oct 15, 2024 at 01:25:07PM -0400, Greg Sabino Mullane wrote: > On Tue, Oct 15, 2024 at 12:25 PM Bruce Momjian wrote: > > Does anyone have suggestions on a character? > > > I poked around with a bunch and the scroll character seems to be the most > appropriate and visibly pleasing.

Re: Detailed release notes

On Tue, Oct 15, 2024 at 12:25 PM Bruce Momjian wrote: > Does anyone have suggestions on a character? I poked around with a bunch and the scroll character seems to be the most appropriate and visibly pleasing. See my posted-before-yours blog post :) https://www.crunchydata.com/blog/enhanced-po

Re: Detailed release notes

I have some good news. Many of you did not like the use of the section symbol as a marker for links from the release notes items to the commit details. I thought we were restricted to Latin-1 characters, because those are the only characters that the PDF output supports. However, since we decide

Re: Detailed release notes

On Tue, Sep 17, 2024 at 08:13:20PM -0400, Bruce Momjian wrote: > I think trying to add text to each item is both redundant and confusing, > because I am guessing that many people will not even know what a commit > is, and will be confused by clicking on the link. > > What I have done is to add tex

Re: Detailed release notes

On Wed, Sep 18, 2024 at 10:16:48AM -0400, Tom Lane wrote: > Jelte Fennema-Nio writes: > > On Wed, 18 Sept 2024 at 02:55, Bruce Momjian wrote: > >>> Also very clutter-y. I'm not convinced that any of this is a good > >>> idea that will stand the test of time: I estimate that approximately > >>> 0

Re: Detailed release notes

Marcos Pegoraro writes: > Em qua., 18 de set. de 2024 às 06:02, Peter Eisentraut > escreveu: >> Maybe this shouldn't be done between RC1 and GA. This is clearly a more >> complex topic that should go through a proper review and testing cycle. > I think this is just a question of decision, not r

Re: Detailed release notes

Jelte Fennema-Nio writes: > On Wed, 18 Sept 2024 at 02:55, Bruce Momjian wrote: >>> Also very clutter-y. I'm not convinced that any of this is a good >>> idea that will stand the test of time: I estimate that approximately >>> 0.01% of people who read the release notes will want these links. >>

Re: Detailed release notes

On Wed, 18 Sept 2024 at 13:38, Marcos Pegoraro wrote: >> Maybe this shouldn't be done between RC1 and GA. This is clearly a more >> complex topic that should go through a proper review and testing cycle. > > I think this is just a question of decision, not reviewing or testing. > And I'm sure the

Re: Detailed release notes

Em qua., 18 de set. de 2024 às 06:02, Peter Eisentraut escreveu: > Maybe this shouldn't be done between RC1 and GA. This is clearly a more > complex topic that should go through a proper review and testing cycle. > I think this is just a question of decision, not reviewing or testing. And I'm s

Re: Detailed release notes

On Wed, Sep 18, 2024 at 8:55 AM Bruce Momjian wrote: > > On Tue, Sep 17, 2024 at 08:22:41PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote: > > >> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera > > >> > > >>> Add back

Re: Detailed release notes

On 2024-Sep-18, Jelte Fennema-Nio wrote: > It seems a shame to remove those links from the HTML view where they > look acceptable and which most people will use, just because they look > bad in the pdf. And honestly, they don't even look that terrible in > the PDF imo. Eh, someday maybe we should

Re: Detailed release notes

On Wed, 18 Sept 2024 at 11:26, Alvaro Herrera wrote: > > On 2024-Sep-17, Bruce Momjian wrote: > > > I think trying to add text to each item is both redundant and confusing, > > because I am guessing that many people will not even know what a commit > > is, and will be confused by clicking on the l

Re: Detailed release notes

On Wed, 18 Sept 2024 at 02:55, Bruce Momjian wrote: > > Also very clutter-y. I'm not convinced that any of this is a good > > idea that will stand the test of time: I estimate that approximately > > 0.01% of people who read the release notes will want these links. > > Yes, I think 0.01% is accura

Re: Detailed release notes

On 2024-Sep-17, Bruce Momjian wrote: > I think trying to add text to each item is both redundant and confusing, > because I am guessing that many people will not even know what a commit > is, and will be confused by clicking on the link. Uh, I 100% disagree that Postgres users reading the release

Re: Detailed release notes

On 18.09.24 02:54, Bruce Momjian wrote: On Tue, Sep 17, 2024 at 08:22:41PM -0400, Tom Lane wrote: Bruce Momjian writes: On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote: Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera Add backend support for injection points (Michael Paq

Re: Detailed release notes

On Tue, Sep 17, 2024 at 08:22:41PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote: > >> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera > >> > >>> Add backend support for injection points (Michael Paquier) [commit 1] [2] >

Re: Detailed release notes

Bruce Momjian writes: > On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote: >> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera >> >>> Add backend support for injection points (Michael Paquier) [commit 1] [2] > I think trying to add text to each item is both redundant and confu

Re: Detailed release notes

On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote: > Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera > escreveu: > > Add backend support for injection points (Michael Paquier) [commit 1] [2] > [3] [4] > > I think this way would be fine. > > And it would be good to hav

Re: Detailed release notes

Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera < alvhe...@alvh.no-ip.org> escreveu: > Add backend support for injection points (Michael Paquier) [commit 1] [2] > [3] [4] > I think this way would be fine. And it would be good to have a target="_blank" on commit links so a new window or tab w

Re: Detailed release notes

On Tue, 17 Sept 2024 at 10:12, Alvaro Herrera wrote: > Maybe it would work to use numbers in square brackets instead: > > Add backend support for injection points (Michael Paquier) [1] [2] [3] [4] Another option would be to add them in superscript using the html tag (or even using some unico

Re: Detailed release notes

On 2024-Sep-16, Bruce Momjian wrote: > We could try: > >Add backend support for injection points (Michael Paquier) §1 §2 §3 §4 > > and maybe only add numbers if there is more than one commit. Well, this reads like references to sections 1, 2, 3 and 4, but they aren't that, and probably such

Re: Detailed release notes

On Mon, Sep 16, 2024 at 03:42:22PM -0300, Marcos Pegoraro wrote: > Em seg., 16 de set. de 2024 às 15:15, Bruce Momjian > escreveu: > > > > I changed the patch to use the section symbol "§" instead of showing > > > the hashes.  The hashes seemed too detailed.  Does anyone see a better >

Re: Detailed release notes

Em seg., 16 de set. de 2024 às 15:15, Bruce Momjian escreveu: > > > I changed the patch to use the section symbol "§" instead of showing > > > the hashes. The hashes seemed too detailed. Does anyone see a better > > > symbol to use from here Well, I think section symbol is not a good choice f

Re: Detailed release notes

On Sat, Sep 14, 2024 at 08:37:31PM -0400, Bruce Momjian wrote: > On Fri, Sep 13, 2024 at 12:39:28PM -0400, Bruce Momjian wrote: > > I applied this patch to PG 17. You can see the results at: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > The community doc build only shows the

Re: Detailed release notes

On Fri, Sep 13, 2024 at 12:39:28PM -0400, Bruce Momjian wrote: > I applied this patch to PG 17. You can see the results at: > > https://momjian.us/pgsql_docs/release-17.html > > The community doc build only shows the master branch, which is PG 18, > and the PG 17 docs are only built before

Re: Detailed release notes

On Fri, Sep 13, 2024 at 05:54:31PM -0400, Bruce Momjian wrote: > On Fri, Sep 13, 2024 at 06:41:30PM -0300, Marcos Pegoraro wrote: > > Em sex., 13 de set. de 2024 às 13:39, Bruce Momjian > > escreveu: > > > > I changed the patch to use the section symbol "§" instead of showing > > the hash

Re: Detailed release notes

On Fri, Sep 13, 2024 at 06:41:30PM -0300, Marcos Pegoraro wrote: > Em sex., 13 de set. de 2024 às 13:39, Bruce Momjian > escreveu: > > I changed the patch to use the section symbol "§" instead of showing > the hashes.  The hashes seemed too detailed.  Does anyone see a better > symbol

Re: Detailed release notes

Em sex., 13 de set. de 2024 às 13:39, Bruce Momjian escreveu: > I changed the patch to use the section symbol "§" instead of showing > the hashes. The hashes seemed too detailed. Does anyone see a better > symbol to use from here? > Robert and others liked commit hashes because you can do "git

Re: Detailed release notes

On Sat, Sep 7, 2024 at 10:12:00AM +0800, jian he wrote: > On Sat, Sep 7, 2024 at 6:30 AM Jelte Fennema-Nio wrote: > > > > On Thu, 22 Aug 2024 at 21:34, Marcos Pegoraro wrote: > > > I understand your point, and agree with that for previous releases, but > > > since we have a month only for versi

Re: Detailed release notes

On Wed, Sep 11, 2024 at 10:16:04AM -0400, Bruce Momjian wrote: > On Sat, Sep 7, 2024 at 10:12:00AM +0800, jian he wrote: > > On Sat, Sep 7, 2024 at 6:30 AM Jelte Fennema-Nio wrote: > > > > > > On Thu, 22 Aug 2024 at 21:34, Marcos Pegoraro wrote: > > > > I understand your point, and agree with th

Re: Detailed release notes

On Sat, Sep 7, 2024 at 10:12:00AM +0800, jian he wrote: > On Sat, Sep 7, 2024 at 6:30 AM Jelte Fennema-Nio wrote: > > > > On Thu, 22 Aug 2024 at 21:34, Marcos Pegoraro wrote: > > > I understand your point, and agree with that for previous releases, but > > > since we have a month only for versi

Re: Detailed release notes

Em sex., 6 de set. de 2024 às 23:13, jian he escreveu: > I didn't manually click each git commit url to test it though. Checked, all commit links are working and matching with their regards Marcos

Re: Detailed release notes

On Sat, Sep 7, 2024 at 6:30 AM Jelte Fennema-Nio wrote: > > On Thu, 22 Aug 2024 at 21:34, Marcos Pegoraro wrote: > > I understand your point, and agree with that for previous releases, but > > since we have a month only for version 17, will this process work properly > > until that date ? > > I

Re: Detailed release notes

On Thu, 22 Aug 2024 at 21:34, Marcos Pegoraro wrote: > I understand your point, and agree with that for previous releases, but since > we have a month only for version 17, will this process work properly until > that date ? > I think a release notes is more read as soon as it is available than o

Re: Detailed release notes

On Wed, Aug 28, 2024 at 10:47:32AM +0200, Peter Eisentraut wrote: > > > > > Change > lock mode output labels (Bruce Momjian) > > > > to > > > > Change > lock mode output labels (Bruce Momjian) > > > Author: Bruce Momjian > 2023-09-2

Re: Detailed release notes

On 22.08.24 19:27, Tom Lane wrote: Marcos Pegoraro writes: Well, a process which does this automatically would be cool, but a modified version of release notes for version 17 was done manually and seems fine. So, why not commit this version and later for version 18 then create this process ?

Re: Detailed release notes

On Fri, Aug 23, 2024 at 11:26:30AM +0800, jian he wrote: > do you mean this thread [1]? but the output is the attached image.png, > which looks more invasive. > also that does not link to git commit url. > > or do you mean automate the process, like add > commit > automatically? using perl script,

Re: Detailed release notes

Em qui., 22 de ago. de 2024 às 14:27, Tom Lane escreveu: > > I'd prefer to see this implemented in the website based on our > existing markup practices. That way it would work for quite a > few years' worth of existing release notes, not only future ones. > > I understand your point, and agree w

Re: Detailed release notes

Marcos Pegoraro writes: > Well, a process which does this automatically would be cool, but a > modified version of release notes for version 17 was done manually and > seems fine. > So, why not commit this version and later for version 18 then create this > process ? I'd prefer to see this implem

Re: Detailed release notes

Em seg., 19 de ago. de 2024 às 19:10, Bruce Momjian escreveu: > Should I work on this? > > Well, a process which does this automatically would be cool, but a modified version of release notes for version 17 was done manually and seems fine. So, why not commit this version and later for version 18

Re: Detailed release notes

On Fri, Jul 26, 2024 at 10:11:22AM -0400, Tom Lane wrote: > Daniel Gustafsson writes: > >> On 26 Jul 2024, at 15:00, Marcos Pegoraro wrote: > >> But why is that just a hidden comment and not a visible link for us ? > > > That's likely the wrong level of detail for the overwhelming majority of >

Re: Detailed release notes

Em seg., 12 de ago. de 2024 às 06:21, jian he escreveu: > > as your wish. > Looks good. regards Marcos

Re: Detailed release notes

On Fri, Aug 9, 2024 at 8:43 PM Marcos Pegoraro wrote: > > I still think this way would be better > + Sawada, John Naylor). [ > + ee1b30f12, > + 30e144287, > + 667e65aac, > + 6dbb49026] > instead of this > + Sawada, John Naylor). > +[ee1b30f12], > +

Re: Detailed release notes

Em qui., 8 de ago. de 2024 às 21:57, jian he escreveu: > > please check attached. > I still think this way would be better + Sawada, John Naylor). [ + ee1b30f12, + 30e144287, + 667e65aac, + 6dbb49026] instead of this + Sawada, John Naylor). +[ee1b30f12]

Re: Detailed release notes

On Thu, Aug 8, 2024 at 8:51 PM Marcos Pegoraro wrote: > > Em qui., 8 de ago. de 2024 às 00:11, jian he > escreveu: >> >> >> adding the following line to postgres.sgml saved me. >> +https://postgr.es/c/";> > > > Comma at end of line of these should be removed > [165d581f1] , > [6dbb49026] , > >

Re: Detailed release notes

Em qui., 8 de ago. de 2024 às 00:11, jian he escreveu: > > adding the following line to postgres.sgml saved me. > +https://postgr.es/c/";> > Comma at end of line of these should be removed [165d581f1] , [6dbb49026] , Maybe those items which have lots of commits would be strange A space before

Re: Detailed release notes

On Tue, Aug 6, 2024 at 11:12 PM Andres Freund wrote: > > Hi, > > On 2024-08-06 12:02:59 -0300, Euler Taveira wrote: > > Talking about the patch, do we want to rely on an external resource? I > > suggest > > that we use a postgresql.org subdomain. It can point to > > > > https://git.postgresql.org

Re: Detailed release notes

Hi, On 2024-08-06 12:02:59 -0300, Euler Taveira wrote: > Talking about the patch, do we want to rely on an external resource? I suggest > that we use a postgresql.org subdomain. It can point to > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=$COMMIT I wonder if we should make

Re: Detailed release notes

On Tue, Aug 6, 2024, at 11:02 AM, Robert Haas wrote: > On Tue, Aug 6, 2024 at 9:57 AM Marcos Pegoraro wrote: > > Loved, except that the commit id does not help too much, so I don't think > > we need it. > > I think a numbered link would be better. > > I think the commit ID is quite useful. If yo

Re: Detailed release notes

On Tue, Aug 6, 2024 at 9:57 AM Marcos Pegoraro wrote: > Loved, except that the commit id does not help too much, so I don't think we > need it. > I think a numbered link would be better. I think the commit ID is quite useful. If you're using git, you can do "git show $COMMITID". If you're using

Re: Detailed release notes

Em ter., 6 de ago. de 2024 às 04:30, jian he escreveu: > > you can also preview the attached screenshot to see the rendered effect. > Loved, except that the commit id does not help too much, so I don't think we need it. I think a numbered link would be better. - Change functions to use a saf

Re: Detailed release notes

On Mon, Aug 5, 2024, at 10:33 AM, Daniel Gustafsson wrote: >> On 5 Aug 2024, at 13:16, Marcos Pegoraro wrote: >> >> Em seg., 5 de ago. de 2024 às 07:54, jian he >> escreveu: >>> >>> [commitId_link1, commitId_link2]: Change functions to use a safe >>> search_path during maintenance operations (

Re: Detailed release notes

> On 5 Aug 2024, at 13:16, Marcos Pegoraro wrote: > > Em seg., 5 de ago. de 2024 às 07:54, jian he > escreveu: >> >> [commitId_link1, commitId_link2]: Change functions to use a safe >> search_path during maintenance operations (Jeff Davis) > > I don't like t

Re: Detailed release notes

Em seg., 5 de ago. de 2024 às 07:54, jian he escreveu: > > [commitId_link1, commitId_link2]: Change functions to use a safe > search_path during maintenance operations (Jeff Davis) > I don't like that prefix dirtying each item. I think having just a link after every item would be better. Firstly

Re: Detailed release notes

On Fri, Jul 26, 2024 at 10:11 PM Tom Lane wrote: > > Daniel Gustafsson writes: > >> On 26 Jul 2024, at 15:00, Marcos Pegoraro wrote: > >> But why is that just a hidden comment and not a visible link for us ? > > > That's likely the wrong level of detail for the overwhelming majority of > > relea

Re: Detailed release notes

Em sex., 26 de jul. de 2024 às 13:01, Masahiko Sawada escreveu: > > +1. I've been asked a lot of times how to find the associated commit > IDs from release note items. These links would help users know the > details of the changes, and I believe many users would like to do > that. Yes, this way

Re: Detailed release notes

On Fri, Jul 26, 2024 at 6:56 AM Robert Haas wrote: > > On Fri, Jul 26, 2024 at 9:26 AM Marcos Pegoraro wrote: > > Well, that opened my eyes, now I can see detailed info about every feature > > when it's committed. > > And I'm really convinced that a small link to that commit wouldn't get > > di

Re: Detailed release notes

Daniel Gustafsson writes: >> On 26 Jul 2024, at 15:00, Marcos Pegoraro wrote: >> But why is that just a hidden comment and not a visible link for us ? > That's likely the wrong level of detail for the overwhelming majority of > release notes readers. I have a feeling this was discussed not too

Re: Detailed release notes

On Fri, Jul 26, 2024 at 9:26 AM Marcos Pegoraro wrote: > Well, that opened my eyes, now I can see detailed info about every feature > when it's committed. > And I'm really convinced that a small link to that commit wouldn't get dirty > release notes. +1. I think those links would be useful to a

Re: Detailed release notes

but (if so) I fail to find that discussion now.Wrong level ? Where is the appropriate place on DOCs to see exactly what I'll get when updated ? A separate page "Detailed Release Notes" ? I don't think so.I think release notes are sometimes the only place we read to decide if a

Re: Detailed release notes

Wrong level ? Where is the appropriate place on DOCs to see exactly what I'll get when updated ? A separate page "Detailed Release Notes" ? I don't think so. I think release notes are sometimes the only place we read to decide if an upgrade is doable or not. Well, that opened my

Re: Detailed release notes

> On 26 Jul 2024, at 15:00, Marcos Pegoraro wrote: > But why is that just a hidden comment and not a visible link for us ? That's likely the wrong level of detail for the overwhelming majority of release notes readers. I have a feeling this was discussed not too long ago but (if so) I fail to f

Re: Detailed release notes

Em sex., 26 de jul. de 2024 às 09:45, Daniel Gustafsson escreveu: > > There is a way, but it's not exactly visible from reading the release > notes. > Cool, didn't know that. But why is that just a hidden comment and not a visible link for us ? regards Marcos

Re: Detailed release notes

> On 26 Jul 2024, at 14:30, Marcos Pegoraro wrote: > > I'm now using version 14 and planning to update to 17 as soon as it comes > available. Then looking carefully to release notes to see exactly what I'll > get when updated I see lots of unexplained features. Just because release > notes doe

Detailed release notes

I'm now using version 14 and planning to update to 17 as soon as it comes available. Then looking carefully to release notes to see exactly what I'll get when updated I see lots of unexplained features. Just because release notes does not explain exactly what that change does. And I don't have a wa