Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-16 Thread Peter Smith
On Thu, May 16, 2024 at 10:42 PM David Rowley wrote: > > On Thu, 16 May 2024 at 19:05, Peter Smith wrote: > > > > On Thu, May 16, 2024 at 3:11 PM David Rowley wrote: > > > If you want to do this, what's the reason to limit it to just this one > > > page of the docs? > > > > Yeah, I had a vested

Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-16 Thread Tom Lane
Peter Smith writes: > Yeah, I had a vested interest in this one place because I've been > reviewing the other thread [1] that was mentioned above. If that other > thread chooses "true|false" then putting "true|false" adjacent to > another "on|off" will look silly. But if that other thread adopts

Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-16 Thread David Rowley
On Thu, 16 May 2024 at 19:05, Peter Smith wrote: > > On Thu, May 16, 2024 at 3:11 PM David Rowley wrote: > > If you want to do this, what's the reason to limit it to just this one > > page of the docs? > > Yeah, I had a vested interest in this one place because I've been > reviewing the other

Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-16 Thread Peter Smith
On Thu, May 16, 2024 at 3:11 PM David Rowley wrote: > > On Thu, 16 May 2024 at 12:29, Peter Smith wrote: > > There are lots of subscription options listed on the CREATE > > SUBSCRIPTION page [1]. > > > > Although these boolean options are capable of accepting different > > values like "1|0",

Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-15 Thread David Rowley
On Thu, 16 May 2024 at 12:29, Peter Smith wrote: > There are lots of subscription options listed on the CREATE > SUBSCRIPTION page [1]. > > Although these boolean options are capable of accepting different > values like "1|0", "on|off", "true|false", here they are all described > only using

Docs: Always use true|false instead of sometimes on|off for the subscription options

2024-05-15 Thread Peter Smith
Hi hackers, There are lots of subscription options listed on the CREATE SUBSCRIPTION page [1]. Although these boolean options are capable of accepting different values like "1|0", "on|off", "true|false", here they are all described only using values "true|false". ~ IMO this consistent way of