On Fri, 23 Feb 2024 at 04:58, Peter Smith wrote:
>
> Hi Vignesh, I have no further comments. Patch v9 LGTM.
The v9 version patch was not applying on top of HEAD because of few
commits, the updated v10 version patch is rebased on top of HEAD.
Regards,
Vignesh
From
Hi Vignesh, I have no further comments. Patch v9 LGTM.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, 22 Feb 2024 at 09:35, Peter Smith wrote:
>
> Here are some minor comments for patch v8-0001.
>
> ==
> doc/src/sgml/glossary.sgml
>
> 1.
> +
> +
> + A set of publisher and subscriber instances with publisher instance
> + replicating changes to the subscriber instance.
>
Here are some minor comments for patch v8-0001.
==
doc/src/sgml/glossary.sgml
1.
+
+
+ A set of publisher and subscriber instances with publisher instance
+ replicating changes to the subscriber instance.
+
+
/with publisher instance/with the publisher instance/
~~~
On Mon, 12 Feb 2024 at 14:33, vignesh C wrote:
>
> On Fri, 9 Feb 2024 at 12:30, Peter Smith wrote:
> >
> > Here are some review comments for patch v7-0001.
> >
> > ==
> > doc/src/sgml/glossary.sgml
> >
> > 1.
> > +
> > + Logical replication cluster
> > +
> > +
> > + A set of
On Fri, 9 Feb 2024 at 12:30, Peter Smith wrote:
>
> Here are some review comments for patch v7-0001.
>
> ==
> doc/src/sgml/glossary.sgml
>
> 1.
> +
> + Logical replication cluster
> +
> +
> + A set of publisher and subscriber instance with publisher instance
> + replicating
On Thu, 1 Feb 2024 at 14:50, vignesh C wrote:
>
> On Wed, 31 Jan 2024 at 11:42, Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Vignesh,
> >
> > Thanks for updating the patch! Here are my comments for v6.
> >
> > 01.
> > ```
> > + Logical replication cluster
> > +
> > +
> > + A set of
Here are some review comments for patch v7-0001.
==
doc/src/sgml/glossary.sgml
1.
+
+ Logical replication cluster
+
+
+ A set of publisher and subscriber instance with publisher instance
+ replicating changes to the subscriber instance.
+
+
+
1a.
/instance
On Wed, 31 Jan 2024 at 11:42, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for updating the patch! Here are my comments for v6.
>
> 01.
> ```
> + Logical replication cluster
> +
> +
> + A set of publisher and subscriber instance with publisher instance
> +
Dear Vignesh,
Thanks for updating the patch! Here are my comments for v6.
01.
```
+ Logical replication cluster
+
+
+ A set of publisher and subscriber instance with publisher instance
+ replicating changes to the subscriber instance.
+
+
```
Should we say 1:N
On Mon, 29 Jan 2024 at 16:01, Bharath Rupireddy
wrote:
>
> On Mon, Jan 29, 2024 at 10:10 AM vignesh C wrote:
> >
> > Thanks for the comments, the attached v5 version patch has the changes
> > for the same.
>
> Thanks for working on this. Here are some comments on the v5 patch:
>
> 1.
> +
> +
On Mon, Jan 29, 2024 at 10:10 AM vignesh C wrote:
>
> Thanks for the comments, the attached v5 version patch has the changes
> for the same.
Thanks for working on this. Here are some comments on the v5 patch:
1.
+
+ Migration of logical replication clusters is possible only when all the
+
On Mon, 29 Jan 2024 at 06:34, Peter Smith wrote:
>
> Hi Vignesh,
>
> Here are some review comments for patch v4.
>
> These are cosmetic only; otherwise v4 LGTM.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1.
> Configure the servers for log shipping. (You do not need to run
>
Dear Vignesh,
Thanks for updating the patch! For now, v4 patch LGTM.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
Hi Vignesh,
Here are some review comments for patch v4.
These are cosmetic only; otherwise v4 LGTM.
==
doc/src/sgml/ref/pgupgrade.sgml
1.
Configure the servers for log shipping. (You do not need to run
pg_backup_start() and
pg_backup_stop()
or take a file system
On Thu, 25 Jan 2024 at 05:45, Peter Smith wrote:
>
> Here are some review comments for patch v3.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1.
> +
> +
> + This page does not cover steps to upgrade logical replication
> clusters, refer
> +for details on upgrading
> + logical
On Wed, 24 Jan 2024 at 15:16, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for updating the patch! Basically your patch looks good.
> Below lines are my comments for v3.
>
> 01.
>
> ```
>
> The output plugins referenced by the slots on the old cluster must be
>
Here are some review comments for patch v3.
==
doc/src/sgml/ref/pgupgrade.sgml
1.
+
+
+ This page does not cover steps to upgrade logical replication
clusters, refer
+for details on upgrading
+ logical replication clusters.
+
+
I felt that maybe this note was misplaced. Won't it
Dear Vignesh,
Thanks for updating the patch! Basically your patch looks good.
Below lines are my comments for v3.
01.
```
The output plugins referenced by the slots on the old cluster must be
installed in the new PostgreSQL executable directory.
```
PostgreSQL must be
On Mon, 15 Jan 2024 at 14:39, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for updating the patch!
>
> > > 7.
> > > ```
> > > +
> > > +dba@node1:/opt/PostgreSQL/postgres//bin$ pg_ctl -D
> > /opt/PostgreSQL/pub_data stop -l logfile
> > > +
> > > ```
> > >
> > > Hmm. I thought you
On Mon, 15 Jan 2024 at 09:01, Peter Smith wrote:
>
> Hi Vignesh, here are some review comments for patch v2-0001.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1.
> +
> +Upgrade logical replication clusters
> +
> +
> + Refer logical
> replication upgrade section
> + for
Dear Vignesh,
Thanks for updating the patch!
> > 7.
> > ```
> > +
> > +dba@node1:/opt/PostgreSQL/postgres//bin$ pg_ctl -D
> /opt/PostgreSQL/pub_data stop -l logfile
> > +
> > ```
> >
> > Hmm. I thought you did not have to show the current directory. You were in
> > the
> > bin dir, but it is
Hi Vignesh, here are some review comments for patch v2-0001.
==
doc/src/sgml/ref/pgupgrade.sgml
1.
+
+Upgrade logical replication clusters
+
+
+ Refer logical
replication upgrade section
+ for details on upgrading logical replication clusters.
+
+
+
+
This renders
On Fri, 5 Jan 2024 at 10:49, Peter Smith wrote:
>
> Here are some review comments for patch v1-0001.
>
> ==
> doc/src/sgml/ref/pgupgrade.sgml
>
> 1. GENERAL - blank lines
>
> Most (but not all) of your procedure steps are preceded by blank lines
> to make them more readable in the SGML. Add
On Fri, 5 Jan 2024 at 09:08, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for making a patch! Below part is my comments.
>
> 1.
> Only two steps were added an id, but I think it should be for all the steps.
> See [1].
I have added wherever it is required as of now.
> 2.
> I'm not
On Wed, 10 Jan 2024 at 15:50, Amit Kapila wrote:
>
> On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
> >
> > We have documentation on how to upgrade "publisher" and "subscriber"
> > at [1], but currently we do not have any documentation on how to
> > upgrade logical replication clusters.
> >
On Mon, Jan 8, 2024 at 12:52 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
> >
> > Hi,
> >
> > We have documentation on how to upgrade "publisher" and "subscriber"
> > at [1], but currently we do not have any documentation on how to
> > upgrade logical
On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
>
> We have documentation on how to upgrade "publisher" and "subscriber"
> at [1], but currently we do not have any documentation on how to
> upgrade logical replication clusters.
> Here is a patch to document how to upgrade different logical
>
On Thu, Jan 4, 2024 at 2:22 PM vignesh C wrote:
>
> Hi,
>
> We have documentation on how to upgrade "publisher" and "subscriber"
> at [1], but currently we do not have any documentation on how to
> upgrade logical replication clusters.
> Here is a patch to document how to upgrade different
On Fri, Jan 5, 2024 at 2:38 PM Hayato Kuroda (Fujitsu)
wrote:
...
> 2.
> I'm not sure it should be listed as step 10. I felt that it should be new
> section.
> At that time other steps like "Prepare for {publisher|subscriber} upgrades"
> can be moved as well.
> Thought?
During my review, I
Here are some review comments for patch v1-0001.
==
doc/src/sgml/ref/pgupgrade.sgml
1. GENERAL - blank lines
Most (but not all) of your procedure steps are preceded by blank lines
to make them more readable in the SGML. Add the missing blank lines
for the steps that didn't have them.
2.
Dear Vignesh,
Thanks for making a patch! Below part is my comments.
1.
Only two steps were added an id, but I think it should be for all the steps.
See [1].
2.
I'm not sure it should be listed as step 10. I felt that it should be new
section.
At that time other steps like "Prepare for
Hi,
We have documentation on how to upgrade "publisher" and "subscriber"
at [1], but currently we do not have any documentation on how to
upgrade logical replication clusters.
Here is a patch to document how to upgrade different logical
replication clusters: a) Upgrade 2 node logical replication
33 matches
Mail list logo
