Re: Does slot_deform_tuple need to care about dropped columns?

2018-11-09 Thread Andres Freund
Hi, On 2018-11-07 12:58:16 -0500, Tom Lane wrote: > Andres Freund writes: > > ... in the case the attribute isn't already deformed, the > > following hunk exists: > > > /* > > * If the attribute's column has been dropped, we force a NULL result. > > * This case should not happen

Re: Does slot_deform_tuple need to care about dropped columns?

2018-11-07 Thread Tom Lane
Andres Freund writes: > ... in the case the attribute isn't already deformed, the > following hunk exists: > /* >* If the attribute's column has been dropped, we force a NULL result. >* This case should not happen in normal use, but it could happen if we >* are

Does slot_deform_tuple need to care about dropped columns?

2018-11-07 Thread Andres Freund
Hi, Currently functions like slot_getattr() first check if the attribute is already deformed: Datum slot_getattr(TupleTableSlot *slot, int attnum, bool *isnull) { ... /* * fast path if desired attribute already cached */ if (attnum <= slot->tts_nvalid) {