On 27.11.24 16:35, Justin Pryzby wrote:
On Wed, Nov 27, 2024 at 04:33:25PM +0100, Peter Eisentraut wrote:
On 26.11.24 14:56, Justin Pryzby wrote:
Since 811af9786b, the palloc'd idxkey's seem to be leaking/accumulating
throughout the command.
I noticed this on the master branch while running AN
On Wed, Nov 27, 2024 at 04:33:25PM +0100, Peter Eisentraut wrote:
> On 26.11.24 14:56, Justin Pryzby wrote:
> > Since 811af9786b, the palloc'd idxkey's seem to be leaking/accumulating
> > throughout the command.
> >
> > I noticed this on the master branch while running ANALYZE on partitioned
> > t
On 26.11.24 14:56, Justin Pryzby wrote:
Since 811af9786b, the palloc'd idxkey's seem to be leaking/accumulating
throughout the command.
I noticed this on the master branch while running ANALYZE on partitioned
table with 600 attributes, even though only 6 were being analyzed.
LOG: level: 3; Bui
rom: Peter Eisentraut
> Date: Thu, 8 Aug 2024 08:27:26 +0200
> Subject: [PATCH v2 1/5] Don't overwrite scan key in systable_beginscan()
...
> Fix that by making a copy of the scan keys passed by the caller and
> make the modifications there.
>
> diff --git a/src/backend/ac
[PATCH v2 1/5] Don't overwrite scan key in systable_beginscan()
[PATCH v2 3/5] Replace gratuitous memmove() with memcpy()
[PATCH v2 4/5] Update some code that handled systable_beginscan()
overwriting scan key
(folding patch 4 into patch 1)
Subject: [PATCH v2 1/5] Don't overwrite scan key in systable_beginscan()
When systable_beginscan() and systable_beginscan_ordered() choose an
index scan, they remap the attribute numbers in the passed-in scan
keys to the attribute numbers of the index, and then write those
remapped attribute n
Noah Misch writes:
> On Thu, Aug 08, 2024 at 08:46:35AM +0200, Peter Eisentraut wrote:
>> I propose to fix that by making a copy of the scan keys passed by the caller
>> and make the modifications there.
> No objection, but this would obsolete at least some of these comments (the
> catcache.c one
On Thu, Aug 08, 2024 at 08:46:35AM +0200, Peter Eisentraut wrote:
> When systable_beginscan() and systable_beginscan_ordered() choose an index
> scan, they remap the attribute numbers in the passed-in scan keys to the
> attribute numbers of the index, and then write those remapped attribute
> numbe
Robert Haas writes:
> On Thu, Aug 8, 2024 at 2:46 AM Peter Eisentraut wrote:
>> I propose to fix that by making a copy of the scan keys passed by the
>> caller and make the modifications there.
> This does have the disadvantage of adding more palloc overhead.
It seems hard to believe that one m
On Thu, Aug 8, 2024 at 2:46 AM Peter Eisentraut wrote:
> When systable_beginscan() and systable_beginscan_ordered() choose an
> index scan, they remap the attribute numbers in the passed-in scan keys
> to the attribute numbers of the index, and then write those remapped
> attribute numbers back in
that this code has been copied between the different index AM over time.
(The nbtree version of this code is literally unchanged since July 1996.)From d968667cf4808f0ff5ff2c3bd37b9bf85c9d4a11 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 8 Aug 2024 08:27:26 +0200
Subject: [PATCH 1/3] Do
11 matches
Mail list logo
