Re: Dubious coding in nbtinsert.c

2021-04-08 Thread Tom Lane
Peter Geoghegan writes: > You had a near-identical complaint about a compiler warning that led > to my commit d64f1cdf2f4 -- that one involved _bt_check_unique()'s > curitup, while this one is about curitemid. While I have no problem > silencing this compiler warning now, I don't see any reason to

Re: Dubious coding in nbtinsert.c

2021-04-08 Thread Peter Geoghegan
On Thu, Apr 8, 2021 at 12:19 PM Tom Lane wrote: > Buildfarm member curculio, which doesn't usually produce > uninitialized-variable warnings, is showing one here: > > nbtinsert.c: In function '_bt_doinsert': > nbtinsert.c:411: warning: 'curitemid' may be used uninitialized in this > function > nb

Dubious coding in nbtinsert.c

2021-04-08 Thread Tom Lane
Buildfarm member curculio, which doesn't usually produce uninitialized-variable warnings, is showing one here: nbtinsert.c: In function '_bt_doinsert': nbtinsert.c:411: warning: 'curitemid' may be used uninitialized in this function nbtinsert.c:411: note: 'curitemid' was declared here I can see i