Re: Ensure that STDERR is empty during connect_ok

2022-02-15 Thread Daniel Gustafsson
> On 6 Feb 2022, at 08:00, Michael Paquier wrote: > > On Wed, Feb 02, 2022 at 03:40:39PM +0100, Daniel Gustafsson wrote: >> As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by >> inspecting STDERR in connect_ok and require it to be empty. This is not >> really >> NSS

Re: Ensure that STDERR is empty during connect_ok

2022-02-05 Thread Michael Paquier
On Wed, Feb 02, 2022 at 03:40:39PM +0100, Daniel Gustafsson wrote: > As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by > inspecting STDERR in connect_ok and require it to be empty. This is not > really > NSS specific, and could help find issues in other libraries as

Re: Ensure that STDERR is empty during connect_ok

2022-02-05 Thread Michael Paquier
On Wed, Feb 02, 2022 at 04:42:09PM +0100, Daniel Gustafsson wrote: > Disclaimer: longer term I would prefer to remove test plan counting like above > and Toms comment downthread. That would be really nice. -- Michael signature.asc Description: PGP signature

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Alvaro Herrera
On 2022-Feb-02, Andrew Dunstan wrote: > On 2/2/22 11:01, Dagfinn Ilmari Mannsåker wrote: > > Rather than waiting for Someone™ to find a suitably-shaped tuit to do a > > whole sweep converting everything to done_testing(), I think we should > > make a habit of converting individual scripts

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Andrew Dunstan
On 2/2/22 11:01, Dagfinn Ilmari Mannsåker wrote: > Tom Lane writes: > >> Daniel Gustafsson writes: >> >>> While I prefer to not plan at all and instead run done_testing(), >>> doing that consistently is for another patch, keeping this with the >>> remainder of the suites. >> +1 to that too,

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > Daniel Gustafsson writes: > >> While I prefer to not plan at all and instead run done_testing(), >> doing that consistently is for another patch, keeping this with the >> remainder of the suites. > > +1 to that too, counting the tests is a pretty useless exercise. Rather

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Alvaro Herrera
On 2022-Feb-02, Daniel Gustafsson wrote: > Making this a subtest in order to not having to change the callers, turns the > patch into the attached. For this we must group the new test with one already > existing test, if we group more into it (which would make more sense) then we > need to

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Daniel Gustafsson
> On 2 Feb 2022, at 16:01, Alvaro Herrera wrote: > > On 2022-Feb-02, Daniel Gustafsson wrote: > >> As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by >> inspecting STDERR in connect_ok and require it to be empty. This is not >> really >> NSS specific, and could

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Tom Lane
Daniel Gustafsson writes: > As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by > inspecting STDERR in connect_ok and require it to be empty. This is not > really > NSS specific, and could help find issues in other libraries as well so I > propose to apply it regardless

Re: Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Alvaro Herrera
On 2022-Feb-02, Daniel Gustafsson wrote: > As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by > inspecting STDERR in connect_ok and require it to be empty. This is not > really > NSS specific, and could help find issues in other libraries as well so I > propose to

Ensure that STDERR is empty during connect_ok

2022-02-02 Thread Daniel Gustafsson
As part of the NSS patchset, quite a few bugs (and NSS quirks) were found by inspecting STDERR in connect_ok and require it to be empty. This is not really NSS specific, and could help find issues in other libraries as well so I propose to apply it regardless of the fate of the NSS patchset.