Re: Error code for checksum failure in origin.c

2021-08-30 Thread Kasahara Tatsuhito
On Mon, Aug 30, 2021 at 5:35 PM Amit Kapila wrote: > > On Fri, Aug 27, 2021 at 12:47 PM Daniel Gustafsson wrote: > > > > > On 27 Aug 2021, at 06:32, Amit Kapila wrote: > > > > > I think we need to backpatch this till 9.6 as this is introduced by > > > commit 5aa2350426. Any objections to that? >

Re: Error code for checksum failure in origin.c

2021-08-30 Thread Amit Kapila
On Fri, Aug 27, 2021 at 12:47 PM Daniel Gustafsson wrote: > > > On 27 Aug 2021, at 06:32, Amit Kapila wrote: > > > I think we need to backpatch this till 9.6 as this is introduced by > > commit 5aa2350426. Any objections to that? > > No, that seems appropriate. > Pushed. -- With Regards, Amit

Re: Error code for checksum failure in origin.c

2021-08-27 Thread Daniel Gustafsson
> On 27 Aug 2021, at 06:32, Amit Kapila wrote: > I think we need to backpatch this till 9.6 as this is introduced by > commit 5aa2350426. Any objections to that? No, that seems appropriate. -- Daniel Gustafsson https://vmware.com/

Re: Error code for checksum failure in origin.c

2021-08-26 Thread Kasahara Tatsuhito
On Fri, Aug 27, 2021 at 1:32 PM Amit Kapila wrote: > > On Thu, Aug 26, 2021 at 4:11 PM Daniel Gustafsson wrote: > > > > > On 26 Aug 2021, at 12:03, Amit Kapila wrote: > > > > > > On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito > > > wrote: > > >> > > >> Hi. > > >> > > >> In the code in src/b

Re: Error code for checksum failure in origin.c

2021-08-26 Thread Michael Paquier
On Fri, Aug 27, 2021 at 10:02:26AM +0530, Amit Kapila wrote: > I think we need to backpatch this till 9.6 as this is introduced by > commit 5aa2350426. Any objections to that? None. -- Michael signature.asc Description: PGP signature

Re: Error code for checksum failure in origin.c

2021-08-26 Thread Amit Kapila
On Thu, Aug 26, 2021 at 4:11 PM Daniel Gustafsson wrote: > > > On 26 Aug 2021, at 12:03, Amit Kapila wrote: > > > > On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito > > wrote: > >> > >> Hi. > >> > >> In the code in src/backend/replication/logical/origin.c, > >> the error code "ERRCODE_CONFIGUR

Re: Error code for checksum failure in origin.c

2021-08-26 Thread Daniel Gustafsson
> On 26 Aug 2021, at 12:03, Amit Kapila wrote: > > On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito > wrote: >> >> Hi. >> >> In the code in src/backend/replication/logical/origin.c, >> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given >> when a checksum check results in an error

Re: Error code for checksum failure in origin.c

2021-08-26 Thread Amit Kapila
On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito wrote: > > Hi. > > In the code in src/backend/replication/logical/origin.c, > the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given > when a checksum check results in an error, > but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.

Error code for checksum failure in origin.c

2021-08-26 Thread Kasahara Tatsuhito
Hi. In the code in src/backend/replication/logical/origin.c, the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given when a checksum check results in an error, but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate. diff --git a/src/backend/replication/logical/orig