> On 22 Mar 2018, at 22:38, Tom Lane wrote:
> This stuff seems reasonably non-controversial, so pushed.
Thanks!
> BTW, really the point of what I'd mentioned before was to avoid having
> dblink_res_error constructing a message out of fragments, which it's
> still doing. I'd thought perhaps we
Daniel Gustafsson writes:
> Being a two-space guy I would like the style to remain that, but I also agree
> that the churn is way too expensive and that it’s considered quite obsolete
> and
> old by many. Cutting that change from the patch makes the remainder more
> palatable.
This stuff seems
> On 22 Mar 2018, at 17:19, Tom Lane wrote:
> In short, I'm not sure it's worth thrashing a lot of our translatable
> strings to enforce a debatable style detail.
I thought I had voiced that exact concern in my previous email, but I totally
missed that.
Being a two-space guy I would like the
Daniel Gustafsson writes:
> [ errdetail_hint_style_v2.patch ]
I started going through this in more detail, and I see that a significant
chunk of the changes are to put two spaces not one between sentences in
errdetail/errhint messages. This is per our style guideline:
Detail and hint messag
> On 19 Mar 2018, at 17:47, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Attached patch ensures that (i) details and hints have leading
>> capitalization,
>> have double spaces after punctuation and ends with period; (ii) context
>> should
>> not be capitalized and should not end with peri
Daniel Gustafsson writes:
> Attached patch ensures that (i) details and hints have leading capitalization,
> have double spaces after punctuation and ends with period; (ii) context should
> not be capitalized and should not end with period; (iii) test .out files match
> the changes.
+1 for cleani
When fixing review comments for error message style on another patch, I noticed
that there were a few error details/hints/contexts that weren’t following the
style guide in the documentation. This might be intentional from when they
were added, or we intentionally avoid changing after the fact to
