On Mon, Oct 20, 2025 at 09:54:52AM +0900, Michael Paquier wrote:
> On Sat, Oct 18, 2025 at 08:55:35AM +0900, Michael Paquier wrote:
> > With the addition of the version check in the binary, there is no
> > downside in documenting this requirement.
>
> Okay, I have added a note about that in the do
On Sat, Oct 18, 2025 at 08:55:35AM +0900, Michael Paquier wrote:
> With the addition of the version check in the binary, there is no
> downside in documenting this requirement.
Okay, I have added a note about that in the docs, then applied your
patch on HEAD. Thanks!
If others would like to appl
On Thu, Oct 9, 2025 at 11:08 PM Michael Paquier wrote:
>
> On Thu, Oct 09, 2025 at 11:22:47AM -0700, Masahiko Sawada wrote:
> > +1, sounds like a good idea to improve user experience. I think we can
> > use the API in pg_combinebackup.c too since it has a similar function,
> > read_pg_version_file
On Sun, Oct 5, 2025 at 9:19 PM Michael Paquier wrote:
>
> Hi all,
> (Adding Euler in CC.)
>
> I have mentioned that on this thread:
> https://www.postgresql.org/message-id/[email protected]
>
> Attempting to execute pg_createsubscriber compiled with a version of
> PG_CONTROL_VERSION inc
Hi,
On Wed, Oct 08, 2025 at 09:22:48AM +0900, Michael Paquier wrote:
> On Tue, Oct 07, 2025 at 11:51:45AM -0700, Masahiko Sawada wrote:
> > Just to be clear, did you mean that pg_checksums and pg_rewind already
> > do such checks? IIUC pg_checksums does CRC check for the control file,
> > and if w
On Tue, Oct 14, 2025 at 1:04 AM Michael Paquier wrote:
>
> On Mon, Oct 13, 2025 at 03:35:06PM -0700, Masahiko Sawada wrote:
> > v1-0001-Introduce-API-able-to-retrieve-contents-of-PG_VER.patch:
> >
> > v1-0002-pg_upgrade-Use-PG_VERSION-generic-routine.patch:
> > v1-0003-pg_createsubscriber-Use-PG_V
Hi all,
(Adding Euler in CC.)
I have mentioned that on this thread:
https://www.postgresql.org/message-id/[email protected]
Attempting to execute pg_createsubscriber compiled with a version of
PG_CONTROL_VERSION incompatible with the standby we want to switch to
a logical replica leads
On Thu, Oct 09, 2025 at 11:22:47AM -0700, Masahiko Sawada wrote:
> +1, sounds like a good idea to improve user experience. I think we can
> use the API in pg_combinebackup.c too since it has a similar function,
> read_pg_version_file().
Please find attached what I am finishing with. At the end, I
On Fri, Oct 17, 2025 at 10:32:32AM +0200, Michael Banck wrote:
> So it seems the decision was that pg_checksums does not need this major
> version check? I agree that it is not entirely obvious is does, but on
> the other hand, those "pg_control CRC value is incorrect" are not
> helpful either. But
On Tue, Oct 14, 2025 at 11:54:26AM -0700, Masahiko Sawada wrote:
> All patches look good to me.
Thanks. I have applied all that after a second look, not planning to
bother about the back branches for pg_createsubscriber.
We may be able to apply the version rules to more tools. pg_checksums
and
On Mon, Oct 13, 2025 at 03:35:06PM -0700, Masahiko Sawada wrote:
> v1-0001-Introduce-API-able-to-retrieve-contents-of-PG_VER.patch:
>
> v1-0002-pg_upgrade-Use-PG_VERSION-generic-routine.patch:
> v1-0003-pg_createsubscriber-Use-PG_VERSION-generic-routin.patch:
Applied both of these.
> The new log
On Tue, Oct 7, 2025 at 5:23 PM Michael Paquier wrote:
>
> On Tue, Oct 07, 2025 at 11:51:45AM -0700, Masahiko Sawada wrote:
> > Just to be clear, did you mean that pg_checksums and pg_rewind already
> > do such checks? IIUC pg_checksums does CRC check for the control file,
> > and if we execute v18
On Tue, Oct 07, 2025 at 11:51:45AM -0700, Masahiko Sawada wrote:
> Just to be clear, did you mean that pg_checksums and pg_rewind already
> do such checks? IIUC pg_checksums does CRC check for the control file,
> and if we execute v18-pg_checksums against v17-cluster we end up with
> a similar erro
13 matches
Mail list logo
