Re: Extra code in commit_ts.h

2021-08-08 Thread David Rowley
On Wed, 4 Aug 2021 at 00:02, David Rowley wrote: > Yeah, I think it can be safely removed. I can do so unless someone > thinks otherwise. Pushed. David

Re: Extra code in commit_ts.h

2021-08-03 Thread David Rowley
On Tue, 3 Aug 2021 at 23:12, Andrey Lepikhov wrote: > > On 3/8/21 15:16, David Rowley wrote: > > it diff 73c986adde5~1.. | grep check_track_commit_timestamp > I think this is waste code. May be delete it? Yeah, I think it can be safely removed. I can do so unless someone thinks otherwise.

Re: Extra code in commit_ts.h

2021-08-03 Thread Andrey Lepikhov
On 3/8/21 15:16, David Rowley wrote: it diff 73c986adde5~1.. | grep check_track_commit_timestamp I think this is waste code. May be delete it? -- regards, Andrey Lepikhov Postgres Professional

Re: Extra code in commit_ts.h

2021-08-03 Thread David Rowley
On Tue, 3 Aug 2021 at 21:36, Andrey V. Lepikhov wrote: > I found two extra code lines in commit_ts.h (see attachment). > They confused me during exploring of the code. If they still needed, may > be add some comments? Going by: $ git config --global diff.renamelimit 1000 $ git diff 73

Extra code in commit_ts.h

2021-08-03 Thread Andrey V. Lepikhov
Hi, I found two extra code lines in commit_ts.h (see attachment). They confused me during exploring of the code. If they still needed, may be add some comments? -- regards, Andrey Lepikhov Postgres Professional diff --git a/src/include/access/commit_ts.h b/src/include/access/commit_ts.h index