Yes sure. Thanks Tom.
On Fri, Feb 1, 2019 at 1:04 AM Tom Lane wrote:
> Since we've reached the end of the January commitfest, and it's pretty
> clear that this patch isn't going to get committed in anything like
> its current form, I'm going to close the CF entry as returned with
> feedback.
Since we've reached the end of the January commitfest, and it's pretty
clear that this patch isn't going to get committed in anything like
its current form, I'm going to close the CF entry as returned with
feedback. If you come up with a follow-on patch, please create a
new CF entry.
Richard Guo writes:
> On Tue, Jan 8, 2019 at 11:29 PM Tom Lane wrote:
>> The bigger picture here, of course, is that check_outerjoin_delay's
>> API is not at all well matched to what check_equivalence_delay needs:
>> it has to make the extra bms_copy shown above, and it has no use
>> for either
On Tue, Jan 8, 2019 at 11:29 PM Tom Lane wrote:
> Richard Guo writes:
> > On Fri, Jan 4, 2019 at 10:32 PM Peter Eisentraut <
> > peter.eisentr...@2ndquadrant.com> wrote:
> >> I think code readability and maintainability would be improved by having
> >> fewer special cases and fast paths. In
Richard Guo writes:
> On Fri, Jan 4, 2019 at 10:32 PM Peter Eisentraut <
> peter.eisentr...@2ndquadrant.com> wrote:
>> I think code readability and maintainability would be improved by having
>> fewer special cases and fast paths. In this particular case, I'd even
>> remove the existing fast
On Fri, Jan 4, 2019 at 10:32 PM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 12/12/2018 08:32, Richard Guo wrote:
> > This small revise is not expected to bring performance improvements, but
> > can improve the readability of the code that for empty relids, the qual
> > is
On 12/12/2018 08:32, Richard Guo wrote:
> This small revise is not expected to bring performance improvements, but
> can improve the readability of the code that for empty relids, the qual
> is always considered as being not-outerjoin_delayed.
I think code readability and maintainability would be
that for empty relids, the qual
is always considered as being not-outerjoin_delayed.
Is this code change worthwhile? Any thoughts?
Thanks
-Richard
Fast-path-for-empty-relids-in-check_outerjoin_delay-v1.patch
Description: Binary data
