Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-24 Thread Dilip Kumar
On Wed, Mar 25, 2020 at 9:23 AM Amit Kapila wrote: > > On Wed, Mar 25, 2020 at 12:46 AM Andres Freund wrote: > > > > On 2020-03-24 18:36:03 +0530, Dilip Kumar wrote: > > > IMHO, I have tried the best case but did not see any performance gain > > > so I am not planning to test this further. I hav

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-24 Thread Amit Kapila
On Wed, Mar 25, 2020 at 12:46 AM Andres Freund wrote: > > On 2020-03-24 18:36:03 +0530, Dilip Kumar wrote: > > IMHO, I have tried the best case but did not see any performance gain > > so I am not planning to test this further. I have attached the patch > > for removing the TODO. > > Pushed. Than

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-24 Thread Andres Freund
On 2020-03-24 18:36:03 +0530, Dilip Kumar wrote: > IMHO, I have tried the best case but did not see any performance gain > so I am not planning to test this further. I have attached the patch > for removing the TODO. Pushed. Thanks!

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-24 Thread Dilip Kumar
On Tue, Mar 24, 2020 at 6:16 PM Amit Kapila wrote: > > On Mon, Mar 9, 2020 at 11:07 PM Andres Freund wrote: > > > > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote: > > > IMHO, if we conclude that because there is no performance gain so we > > > don't want to add one extra path in the code then w

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-24 Thread Amit Kapila
On Mon, Mar 9, 2020 at 11:07 PM Andres Freund wrote: > > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote: > > IMHO, if we conclude that because there is no performance gain so we > > don't want to add one extra path in the code then we might want to > > remove that TODO from the code so that we do

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-09 Thread Andres Freund
On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote: > IMHO, if we conclude that because there is no performance gain so we > don't want to add one extra path in the code then we might want to > remove that TODO from the code so that we don't spend time for > optimizing this in the future. +1

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-08 Thread Dilip Kumar
On Sun, Mar 8, 2020 at 9:24 PM James Coleman wrote: > > On Saturday, March 7, 2020, Dilip Kumar wrote: >> >> On Sat, Mar 7, 2020 at 9:59 AM Dilip Kumar wrote: >> > >> > On Sat, Mar 7, 2020 at 12:30 AM Andres Freund wrote: >> > > >> > > Hi, >> > > >> > > On 2020-01-08 18:06:52 +0530, Dilip Kumar

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-08 Thread James Coleman
On Saturday, March 7, 2020, Dilip Kumar wrote: > On Sat, Mar 7, 2020 at 9:59 AM Dilip Kumar wrote: > > > > On Sat, Mar 7, 2020 at 12:30 AM Andres Freund > wrote: > > > > > > Hi, > > > > > > On 2020-01-08 18:06:52 +0530, Dilip Kumar wrote: > > > > On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakanga

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-06 Thread Dilip Kumar
On Sat, Mar 7, 2020 at 9:59 AM Dilip Kumar wrote: > > On Sat, Mar 7, 2020 at 12:30 AM Andres Freund wrote: > > > > Hi, > > > > On 2020-01-08 18:06:52 +0530, Dilip Kumar wrote: > > > On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas wrote: > > > > > > > On 25/11/2019 05:52, Dilip Kumar wrote: > >

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-06 Thread Dilip Kumar
On Sat, Mar 7, 2020 at 12:30 AM Andres Freund wrote: > > Hi, > > On 2020-01-08 18:06:52 +0530, Dilip Kumar wrote: > > On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas wrote: > > > > > On 25/11/2019 05:52, Dilip Kumar wrote: > > > > In logical decoding, while sending the changes to the output plu

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-06 Thread Andres Freund
Hi, On 2020-01-08 18:06:52 +0530, Dilip Kumar wrote: > On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas wrote: > > > On 25/11/2019 05:52, Dilip Kumar wrote: > > > In logical decoding, while sending the changes to the output plugin we > > > need to arrange them in the LSN order. But, if there i

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-03 Thread Dilip Kumar
On Wed, Mar 4, 2020 at 3:02 AM David Zhang wrote: > > Hi Dilip, > > I repeated the same test cases again and can't reproduce the > disconnection issue after applied your new patch. Thanks for the confirmation. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-03 Thread David Zhang
Hi Dilip, I repeated the same test cases again and can't reproduce the disconnection issue after applied your new patch. Best regards, David On 2020-03-02 9:11 p.m., Dilip Kumar wrote: On Wed, Feb 19, 2020 at 6:00 AM David Zhang wrote: After manually applied the patch, a diff regenerated

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-02 Thread Dilip Kumar
On Wed, Feb 19, 2020 at 6:00 AM David Zhang wrote: > > After manually applied the patch, a diff regenerated is attached. > > On 2020-02-18 4:16 p.m., David Zhang wrote: > > 1. Tried to apply the patch to PG 12.2 commit > > 45b88269a353ad93744772791feb6d01bc7e1e42 (HEAD -> REL_12_2, tag: REL_12_2)

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-02 Thread Dilip Kumar
On Tue, Mar 3, 2020 at 8:42 AM Dilip Kumar wrote: > > On Mon, Mar 2, 2020 at 7:27 PM David Steele wrote: > > > > Hi Dilip, > > > > On 2/18/20 7:30 PM, David Zhang wrote: > > > After manually applied the patch, a diff regenerated is attached. > > > > David's updated patch applies but all logical d

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-02 Thread Dilip Kumar
On Mon, Mar 2, 2020 at 7:27 PM David Steele wrote: > > Hi Dilip, > > On 2/18/20 7:30 PM, David Zhang wrote: > > After manually applied the patch, a diff regenerated is attached. > > David's updated patch applies but all logical decoding regression tests > are failing on cfbot. > > Do you know when

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-03-02 Thread David Steele
Hi Dilip, On 2/18/20 7:30 PM, David Zhang wrote: After manually applied the patch, a diff regenerated is attached. David's updated patch applies but all logical decoding regression tests are failing on cfbot. Do you know when you will be able to supply an updated patch? Regards, -- -David

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-02-18 Thread David Zhang
After manually applied the patch, a diff regenerated is attached. On 2020-02-18 4:16 p.m., David Zhang wrote: 1. Tried to apply the patch to PG 12.2 commit 45b88269a353ad93744772791feb6d01bc7e1e42 (HEAD -> REL_12_2, tag: REL_12_2), it doesn't work. Then tried to check the patch, and found the

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-02-18 Thread David Zhang
1. Tried to apply the patch to PG 12.2 commit 45b88269a353ad93744772791feb6d01bc7e1e42 (HEAD -> REL_12_2, tag: REL_12_2), it doesn't work. Then tried to check the patch, and found the errors showing below. $ git apply --check 0001-Fastpath-for-sending-changes-to-output-plugin-in-log.patch error:

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-01-08 Thread Dilip Kumar
On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas wrote: > On 25/11/2019 05:52, Dilip Kumar wrote: > > In logical decoding, while sending the changes to the output plugin we > > need to arrange them in the LSN order. But, if there is only one > > transaction which is a very common case then we c

Re: Fastpath while arranging the changes in LSN order in logical decoding

2020-01-08 Thread Heikki Linnakangas
On 25/11/2019 05:52, Dilip Kumar wrote: In logical decoding, while sending the changes to the output plugin we need to arrange them in the LSN order. But, if there is only one transaction which is a very common case then we can avoid building the binary heap. A small patch is attached for the s

Re: Fastpath while arranging the changes in LSN order in logical decoding

2019-12-16 Thread Dilip Kumar
On Mon, Nov 25, 2019 at 9:22 AM Dilip Kumar wrote: > > In logical decoding, while sending the changes to the output plugin we > need to arrange them in the LSN order. But, if there is only one > transaction which is a very common case then we can avoid building the > binary heap. A small patch i

Fastpath while arranging the changes in LSN order in logical decoding

2019-11-24 Thread Dilip Kumar
In logical decoding, while sending the changes to the output plugin we need to arrange them in the LSN order. But, if there is only one transaction which is a very common case then we can avoid building the binary heap. A small patch is attached for the same. -- Regards, Dilip Kumar EnterpriseD