On Wed, Jan 17, 2024 at 12:18:12PM +0800, Yongtao Huang wrote:
> Thank you. I prefer to keep the comments of these three functions
> *DecodeInsert()*, *DecodeUpdate()*, and *DecodeDelete()* aligned.
Not sure either what we would gain with a more complicated description
in this area knowing that
Thank you. I prefer to keep the comments of these three functions
*DecodeInsert()*, *DecodeUpdate()*, and *DecodeDelete()* aligned.
```
/*
* Parse XLOG_HEAP_INSERT (not MULTI_INSERT!) records into tuplebufs.
*
* Inserts can contain the new tuple.
*/
static void
On Wed, Jan 17, 2024 at 8:47 AM Yongtao Huang
wrote:
> Hi all,
> I think the comment above the function DecodeInsert()
> in src/backend/replication/logical/decode.c should be
> + * *Inserts *can contain the new tuple.
> , rather than
> - * *Deletes *can contain the new tuple.
>
Nice catch. +1.
Hi all,
I think the comment above the function DecodeInsert()
in src/backend/replication/logical/decode.c should be
+ * *Inserts *can contain the new tuple.
, rather than
- * *Deletes *can contain the new tuple.
Please correct me if I'm wrong, thanks a lot.
