Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-04-18 Thread Peter Eisentraut
On 2019-03-25 09:04, Peter Eisentraut wrote: > So perhaps push the check down to GetRelationPublicationActions() > instead. That way we don't have to patch up two places and everything > "just works" even for possible other callers. See attached patch. This has been committed and backpatched to

Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-25 Thread Peter Eisentraut
ment, 24x7 Support, Remote DBA, Training & Services From 55255a6e338ccb11b4a7a8d6f10aff7a805cd72b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 25 Mar 2019 09:00:14 +0100 Subject: [PATCH v2] Fix handling of unlogged tables in FOR ALL TABLES publications If a FOR ALL TABLES publ

Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-14 Thread Kyotaro HORIGUCHI
At Thu, 14 Mar 2019 15:31:03 +0900, Amit Langote wrote in <26bfa053-3fb2-ad1d-efbb-7c930b41c...@lab.ntt.co.jp> > On 2019/03/14 15:03, Kyotaro HORIGUCHI wrote: > > Is it the right thing that GetRelationPublicationsActions sets > > wrong rd_publicatons for the relations? > > Actually, after

Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-14 Thread Amit Langote
On 2019/03/14 15:03, Kyotaro HORIGUCHI wrote: > At Thu, 14 Mar 2019 11:30:12 +0900, Amit Langote > wrote in > <59e5a734-9e06-1035-385b-626717581...@lab.ntt.co.jp> >> On 2019/03/13 21:03, Peter Eisentraut wrote: >>> If a FOR ALL TABLES publication exists, unlogged tables are ignored >>> for

Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-14 Thread Kyotaro HORIGUCHI
At Thu, 14 Mar 2019 11:30:12 +0900, Amit Langote wrote in <59e5a734-9e06-1035-385b-626717581...@lab.ntt.co.jp> > On 2019/03/13 21:03, Peter Eisentraut wrote: > > If a FOR ALL TABLES publication exists, unlogged tables are ignored > > for publishing changes. But CheckCmdReplicaIdentity() would

Re: Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-13 Thread Amit Langote
On 2019/03/13 21:03, Peter Eisentraut wrote: > If a FOR ALL TABLES publication exists, unlogged tables are ignored > for publishing changes. But CheckCmdReplicaIdentity() would still > check in that case that such a table has a replica identity set before > accepting updates. That is useless, so

Fix handling of unlogged tables in FOR ALL TABLES publications

2019-03-13 Thread Peter Eisentraut
13:00:09 +0100 Subject: [PATCH] Fix handling of unlogged tables in FOR ALL TABLES publications If a FOR ALL TABLES publication exists, unlogged tables are ignored for publishing changes. But CheckCmdReplicaIdentity() would still check in that case that such a table has a replica identity set be