Re: Fix incorrect function comment of stringToNodeInternal

2025-10-18 Thread Daniel Gustafsson
> On 23 Sep 2025, at 09:50, Chao Li wrote: > Again, found an incorrect function comment of stringToNodeInternal(). Wrong > function name is put to the comment, I guess it was from a copy/paste error. I think this is intentional, and the proposed change would not improve it. The comment refers

Re: Fix incorrect function comment of stringToNodeInternal

2025-09-25 Thread Chao Li
> On Sep 25, 2025, at 17:54, Daniel Gustafsson wrote: > >> On 25 Sep 2025, at 10:01, Chao Li wrote: > >> There are 5 different cases, showing that there is not a unique way for what >> function name should be put to xxInternal() functions’ comment. >> >> Is it deserve to take this opportuni

Re: Fix incorrect function comment of stringToNodeInternal

2025-09-25 Thread Daniel Gustafsson
> On 25 Sep 2025, at 10:01, Chao Li wrote: > There are 5 different cases, showing that there is not a unique way for what > function name should be put to xxInternal() functions’ comment. > > Is it deserve to take this opportunity to make all of them in a consistent > format? We don't have a

Re: Fix incorrect function comment of stringToNodeInternal

2025-09-25 Thread Chao Li
Hi Daniel, Thanks for taking care of this patch. > On Sep 25, 2025, at 15:46, Daniel Gustafsson wrote: > >> On 23 Sep 2025, at 09:50, Chao Li wrote: > >> Again, found an incorrect function comment of stringToNodeInternal(). Wrong >> function name is put to the comment, I guess it was from a

Fix incorrect function comment of stringToNodeInternal

2025-09-23 Thread Chao Li
Hi, Again, found an incorrect function comment of stringToNodeInternal(). Wrong function name is put to the comment, I guess it was from a copy/paste error. Best regards, Chao Li (Evan) - HighGo Software Co., Ltd. https://www.highgo.com/ v1-0001-Fix-incorrect-function-commen