Re: Fix pkg-config file for static linking

2021-09-06 Thread Peter Eisentraut
On 05.09.21 21:57, Tom Lane wrote: Peter Eisentraut writes: Makes sense. I think we could do it without hardcoding those library names, as in the attached patch. But it comes out to the same result AFAICT. This has been pushed, but the CF entry is still open, which is making the cfbot

Re: Fix pkg-config file for static linking

2021-09-05 Thread Tom Lane
Peter Eisentraut writes: > Makes sense. I think we could do it without hardcoding those library > names, as in the attached patch. But it comes out to the same result > AFAICT. This has been pushed, but the CF entry is still open, which is making the cfbot unhappy. Were you leaving it open

Re: Fix pkg-config file for static linking

2021-09-02 Thread Filip Gospodinov
On 02.09.21 13:07, Peter Eisentraut wrote: On 20.07.21 22:04, Filip Gospodinov wrote: Anyway, this issue is orthogonal to my original patch. I'm proposing to hardcode -lpgcommon and -lpgport in Libs.private instead. Patch is attached. Makes sense.  I think we could do it without hardcoding

Re: Fix pkg-config file for static linking

2021-09-02 Thread Peter Eisentraut
On 20.07.21 22:04, Filip Gospodinov wrote: Anyway, this issue is orthogonal to my original patch. I'm proposing to hardcode -lpgcommon and -lpgport in Libs.private instead. Patch is attached. Makes sense. I think we could do it without hardcoding those library names, as in the attached

Re: Fix pkg-config file for static linking

2021-07-20 Thread Filip Gospodinov
On 06.07.21 15:13, Peter Eisentraut wrote: This doesn't work. This patch adds libpgcommon and libpgport to Requires.private.  But they are not pkg-config names but library names, so they should be added to Libs.private. Then, I must admit that I have misunderstood this patch at first

Re: Fix pkg-config file for static linking

2021-07-06 Thread Peter Eisentraut
On 21.06.21 15:47, Filip Gospodinov wrote: -PKG_CONFIG_REQUIRES_PRIVATE = libssl libcrypto +PKG_CONFIG_REQUIRES_PRIVATE = libpgcommon libpgport libssl libcrypto This doesn't work. This patch adds libpgcommon and libpgport to Requires.private. But they are not pkg-config names but library

Fix pkg-config file for static linking

2021-06-21 Thread Filip Gospodinov
Since https://github.com/postgres/postgres/commit/ea53100d5 (or Postgres 12.0) the shipped pkg-config file is broken for statically linking libpq because libpgcommon and libpgport are missing. This patch adds those two missing private dependencies. diff --git a/src/interfaces/libpq/Makefile