Re: Fix typo about WalSndPrepareWrite

2021-02-17 Thread japin
On Thu, 18 Feb 2021 at 02:13, Cary Huang wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:tested, passed

Re: Fix typo about WalSndPrepareWrite

2021-02-17 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hi, thanks for the patch, however I don't think it is a

Re: Fix typo about WalSndPrepareWrite

2021-01-14 Thread japin
On Thu, 14 Jan 2021 at 15:32, Kyotaro Horiguchi wrote: > At Thu, 14 Jan 2021 06:46:35 +, Li Japin wrote in >> >> On Jan 14, 2021, at 12:56 PM, Ashutosh Bapat >> mailto:ashutosh.bapat@gmail.com>> wrote: >> >> Hi Japin, >> Thanks for the report. >> >> I think that comment is correct.

Re: Fix typo about WalSndPrepareWrite

2021-01-13 Thread Kyotaro Horiguchi
At Thu, 14 Jan 2021 06:46:35 +, Li Japin wrote in > > On Jan 14, 2021, at 12:56 PM, Ashutosh Bapat > mailto:ashutosh.bapat@gmail.com>> wrote: > > Hi Japin, > Thanks for the report. > > I think that comment is correct. It refers to the following code > blocks of XLogSendPhysical() >

Re: Fix typo about WalSndPrepareWrite

2021-01-13 Thread Li Japin
On Jan 14, 2021, at 12:56 PM, Ashutosh Bapat mailto:ashutosh.bapat@gmail.com>> wrote: Hi Japin, Thanks for the report. I think that comment is correct. It refers to the following code blocks of XLogSendPhysical() 2744 /* 2745 * OK to read and send the slice. 2746 */ 2747

Re: Fix typo about WalSndPrepareWrite

2021-01-13 Thread Ashutosh Bapat
Hi Japin, Thanks for the report. I think that comment is correct. It refers to the following code blocks of XLogSendPhysical() 2744 /* 2745 * OK to read and send the slice. 2746 */ 2747 resetStringInfo(_message); 2748 pq_sendbyte(_message, 'w'); 2749 2750

Fix typo about WalSndPrepareWrite

2021-01-13 Thread japin
WenWu Information Technology Co.,Ltd. >From a5b710e744fe25e10f5a9480d3976ed36fa241ea Mon Sep 17 00:00:00 2001 From: Japin Li Date: Thu, 14 Jan 2021 12:23:56 +0800 Subject: [PATCH v1 1/1] Fix typo about WalSndPrepareWrite WalSndPrepareWrite function comment uses XLogSendPhysical to f