On Sun, May 26, 2019 at 06:43:41PM +0300, Alexander Lakhin wrote:
> 26.05.2019 16:49, Amit Kapila wrote:
> > This occurred to me as well while reviewing, but I thought typo fixes
> > should be fine. Anyway, I have excluded those before pushing. So, if
> > we want to fix these, then maybe one has
26.05.2019 16:49, Amit Kapila wrote:
> This occurred to me as well while reviewing, but I thought typo fixes
> should be fine. Anyway, I have excluded those before pushing. So, if
> we want to fix these, then maybe one has to first get this fixed in
> upstream first and then take from there.
>
On Sat, May 25, 2019 at 8:36 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > I have taken one pass over it and all fixes seem to be correct and got
> > introduced in v12. I will re-verify them once again and then commit
> > your patch if I don't found any problem. In the meantime, if anyone
> >
Amit Kapila writes:
> I have taken one pass over it and all fixes seem to be correct and got
> introduced in v12. I will re-verify them once again and then commit
> your patch if I don't found any problem. In the meantime, if anyone
> else wants to look at it, that would be great.
FWIW, I'd
On Sat, May 25, 2019 at 4:23 PM Alexander Lakhin wrote:
>
> Hello Amit,
>
> 25.05.2019 13:42, Amit Kapila wrote:
> > I think it is good to fix these. I haven't verified all but I can
> > review them. Isn't it better to fix them as one patch instead of
> > multiple patches?
>
> If a single patch
Hello Amit,
25.05.2019 13:42, Amit Kapila wrote:
> I think it is good to fix these. I haven't verified all but I can
> review them. Isn't it better to fix them as one patch instead of
> multiple patches?
If a single patch is more convenient, then here it is.
I thought that separate patches
On Sat, May 25, 2019 at 3:56 PM Alexander Lakhin wrote:
>
> Hello hackers,
>
> I've done another round of cross-checking the master branch for new
> unique identifiers/words. As my previous attempt to fix things was not
> noticed, now I'm focusing on distinct typos.
> 1. authenticaion
Hello hackers,
I've done another round of cross-checking the master branch for new
unique identifiers/words. As my previous attempt to fix things was not
noticed, now I'm focusing on distinct typos.
1. authenticaion (user-visible string)
2. becuase
3. checkinunique
4. cheep
5. comparion
