Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-27 Thread Bertrand Drouvot
t-3.compute.internal Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com >From ffe65b418be46a8b4d9f5e51891967abbff96f86 Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Mon, 1 Sep 2025 10:54:35 + Subject: [PATCH v3] Get rid of pgstat_count_back

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-25 Thread Bertrand Drouvot
Hi, On Thu, Sep 25, 2025 at 03:42:33PM +0900, Michael Paquier wrote: > On Wed, Sep 24, 2025 at 07:48:32AM +, Bertrand Drouvot wrote: > > On Wed, Sep 03, 2025 at 07:33:37AM +, Bertrand Drouvot wrote: > >> As far the ordering concern for v1, what about: > >> > >> - let backend kind enum def

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-24 Thread Michael Paquier
On Wed, Sep 24, 2025 at 07:48:32AM +, Bertrand Drouvot wrote: > On Wed, Sep 03, 2025 at 07:33:37AM +, Bertrand Drouvot wrote: >> As far the ordering concern for v1, what about: >> >> - let backend kind enum defined as 6 >> - move the backend flush outside of the loop in pgstat_report_stat(

Get rid of pgstat_count_backend_io_op*() functions

2025-09-03 Thread Bertrand Drouvot
mazon.com >From 7d00ae64adaed2f1c10c45af79f9eefea86c126a Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Mon, 1 Sep 2025 10:54:35 + Subject: [PATCH v1] Get rid of pgstat_count_backend_io_op*() functions This commit removes the functions that are incrementing the backend IO stats. Inst

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-03 Thread Bertrand Drouvot
Hi, On Wed, Sep 03, 2025 at 02:47:51PM +0900, Michael Paquier wrote: > On Tue, Sep 02, 2025 at 12:42:54PM -0400, Andres Freund wrote: > > I think that's the wrong direction to go. Diffing stats is far from cheap > > and > > gets more expensive the more detail you add to stats. > > Even if we onl

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-02 Thread Michael Paquier
On Tue, Sep 02, 2025 at 12:42:54PM -0400, Andres Freund wrote: > On 2025-09-02 08:19:22 +0900, Michael Paquier wrote: >> On Mon, Sep 01, 2025 at 02:07:27PM +, Bertrand Drouvot wrote: >>> Instead, it now copies the IO pending stats to the backend IO pending stats >>> when >>> the pending IO sta

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-02 Thread Michael Paquier
On Mon, Sep 01, 2025 at 02:07:27PM +, Bertrand Drouvot wrote: > Instead, it now copies the IO pending stats to the backend IO pending stats > when > the pending IO stats are flushed. This behaves the same way as for some > relation > and database stats (see pgstat_relation_flush_cb()). > > I

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-02 Thread Andres Freund
Hi, On 2025-09-02 08:19:22 +0900, Michael Paquier wrote: > On Mon, Sep 01, 2025 at 02:07:27PM +, Bertrand Drouvot wrote: > > Instead, it now copies the IO pending stats to the backend IO pending stats > > when > > the pending IO stats are flushed. This behaves the same way as for some > > re

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-02 Thread Bertrand Drouvot
369434f9cfa9d51dd7aca0 Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Mon, 1 Sep 2025 10:54:35 + Subject: [PATCH v2] Get rid of pgstat_count_backend_io_op*() functions This commit removes the functions that are incrementing the backend IO stats. Instead, it now uses a "global" IO

Re: Get rid of pgstat_count_backend_io_op*() functions

2025-09-02 Thread Bertrand Drouvot
Hi, On Tue, Sep 02, 2025 at 08:19:22AM +0900, Michael Paquier wrote: > On Mon, Sep 01, 2025 at 02:07:27PM +, Bertrand Drouvot wrote: > > Instead, it now copies the IO pending stats to the backend IO pending stats > > when > > the pending IO stats are flushed. This behaves the same way as for