Re: Handling RestrictInfo in expression_tree_walker

2019-08-07 Thread Tom Lane
Konstantin Knizhnik writes: > Frankly speaking I do not see some good reasons for not handling > RestrictInfo in expression_tree_worker. It can really simplify writing > of mutators/walkers. I don't buy this; what seems more likely is that you're trying to apply an expression tree mutator to so

Re: Handling RestrictInfo in expression_tree_walker

2019-08-07 Thread Amit Langote
Hi, On Wed, Aug 7, 2019 at 5:07 PM Konstantin Knizhnik wrote: > On 07.08.2019 10:42, Amit Langote wrote: > > You may also want to read this discussion: > > > > https://www.postgresql.org/message-id/553FC9BC.5060402%402ndquadrant.com > > > Thank you very much for response and pointing me to this t

Re: Handling RestrictInfo in expression_tree_walker

2019-08-07 Thread Konstantin Knizhnik
lker, context); } Are there any complaints against handling RestrictInfo in expression_tree_walker? As I understand it, RestrictInfo is not something that appears in query trees or plan trees, but only in the planner data structures as means of caching some information about the clauses that they wrap. I

Re: Handling RestrictInfo in expression_tree_walker

2019-08-07 Thread Amit Langote
return false; > } > return expression_tree_walker(node, change_varno_walker, context); > } > > Are there any complaints against handling RestrictInfo in > expression_tree_walker? As I understand it, RestrictInfo is not something that appears in query trees or plan trees, but

Handling RestrictInfo in expression_tree_walker

2019-08-07 Thread Konstantin Knizhnik
estrictInfo*)node, context->oldRelid, context->newRelid);         return false;     }     return expression_tree_walker(node, change_varno_walker, context); } Are there any complaints against handling RestrictInfo in expression_tree_walker? -- Konstantin Knizhnik Postgres Professional