Re: Ignore heap rewrites for materialized views in logical replication

2022-06-03 Thread Amit Kapila
On Wed, Jun 1, 2022 at 10:39 AM Amit Kapila wrote: > > On Tue, May 31, 2022 at 8:28 PM Euler Taveira wrote: > > > > On Tue, May 31, 2022, at 11:13 AM, Amit Kapila wrote: > > > > I think we don't need the retry logical to check error, a simple > > wait_for_caught_up should be sufficient as we are

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-31 Thread Amit Kapila
On Tue, May 31, 2022 at 8:28 PM Euler Taveira wrote: > > On Tue, May 31, 2022, at 11:13 AM, Amit Kapila wrote: > > I think we don't need the retry logical to check error, a simple > wait_for_caught_up should be sufficient as we are doing in other > tests. See attached. I have slightly modified the

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-31 Thread Euler Taveira
On Tue, May 31, 2022, at 11:13 AM, Amit Kapila wrote: > I think we don't need the retry logical to check error, a simple > wait_for_caught_up should be sufficient as we are doing in other > tests. See attached. I have slightly modified the commit message as > well. Kindly let me know what you think

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-31 Thread Amit Kapila
On Tue, May 31, 2022 at 6:27 AM Euler Taveira wrote: > > On Sat, May 28, 2022, at 7:07 AM, Amit Kapila wrote: > > I agree with your analysis and the fix looks correct to me. > > Thanks for checking. > > Instead of waiting for an error, we can try to insert into a new table > created by the test ca

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-30 Thread Euler Taveira
: Fri, 27 May 2022 11:35:27 -0300 Subject: [PATCH v2 1/2] Ignore heap rewrites for materialized views in logical replication If you have a publication that specifies FOR ALL TABLES clause, a REFRESH MATERIALIZED VIEW can break your setup with the following message ERROR: logical replication targ

Re: Ignore heap rewrites for materialized views in logical replication

2022-05-28 Thread Amit Kapila
On Sat, May 28, 2022 at 2:44 AM Euler Taveira wrote: > > While investigating an internal report, I concluded that it is a bug. The > reproducible test case is simple (check 0002) and it consists of a FOR ALL > TABLES publication and a non-empty materialized view on publisher. After the > setup, if

Ignore heap rewrites for materialized views in logical replication

2022-05-27 Thread Euler Taveira
dditional test is crucial here. -- Euler Taveira EDB https://www.enterprisedb.com/ From 652efe45665d91f2f4ae865dba078fcaffdc0a17 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Fri, 27 May 2022 11:35:27 -0300 Subject: [PATCH v1 1/2] Ignore heap rewrites for materialized views in logical r