Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-10-02 Thread Michael Paquier
On Sun, Oct 02, 2022 at 10:02:37AM -0700, Andres Freund wrote: > This fails tests widely, and has so for a while: > https://cirrus-ci.com/build/4862820121575424 > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3649 > > Note that it causes timeouts, which end up chewing up

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-10-02 Thread Andres Freund
Hi, On 2022-07-29 16:15:26 -0500, Justin Pryzby wrote: > This was using the old psql rather than the new one. > Before v10, psql didn't have \if. > > I think Cluster.pm should be updated to support the upgrades that upgrade.sh > supported. I guess it ought to be fixed in v15. This fails tests

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-07-31 Thread Anton A. Melnikov
Hello! On 30.07.2022 10:29, Michael Paquier wrote: [ - 'psql', '-X', + "$newbindir/psql", '-X', Found that adding $newbindir to psql gives an error when upgrading from versions 14 and below to master when the test tries to run

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-07-30 Thread Michael Paquier
On Fri, Jul 29, 2022 at 04:15:26PM -0500, Justin Pryzby wrote: > This was using the old psql rather than the new one. > Before v10, psql didn't have \if. # Note that upgrade_adapt.sql from the new version is used, to # cope with an upgrade to this version. -

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-07-29 Thread Justin Pryzby
On Wed, Jul 06, 2022 at 03:27:28PM +0900, Michael Paquier wrote: > On Thu, Jun 09, 2022 at 04:49:01PM +0900, Michael Paquier wrote: > > Rebased to cope with the recent changes in this area. > > Please find attached an updated version of this patch, where I have > extended the support of the

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-07-06 Thread Michael Paquier
On Thu, Jun 09, 2022 at 04:49:01PM +0900, Michael Paquier wrote: > Rebased to cope with the recent changes in this area. Please find attached an updated version of this patch, where I have extended the support of the upgrade script down to 9.5 as origin version, as ~9.4 now fail because of

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-13 Thread Andrew Dunstan
On 2022-06-13 Mo 03:51, Michael Paquier wrote: > On Sun, Jun 12, 2022 at 05:58:54PM -0400, Andrew Dunstan wrote: >> On 2022-06-12 Su 10:14, Andrew Dunstan wrote: >>> I tried in fb16d2c658 to avoid littering the mainline code with >>> version-specific tests, and put that in the methods in the

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-13 Thread Michael Paquier
On Sun, Jun 12, 2022 at 05:58:54PM -0400, Andrew Dunstan wrote: > On 2022-06-12 Su 10:14, Andrew Dunstan wrote: >> I tried in fb16d2c658 to avoid littering the mainline code with >> version-specific tests, and put that in the methods in the subclasses >> that override the mainline functions.

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-12 Thread Andrew Dunstan
On 2022-06-12 Su 10:14, Andrew Dunstan wrote: > On 2022-06-09 Th 03:49, Michael Paquier wrote: >> On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: >>> On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: (Adding Andrew Dunstan in CC.) I have been toying

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-12 Thread Andrew Dunstan
On 2022-06-09 Th 03:49, Michael Paquier wrote: > On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: >> On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: >>> (Adding Andrew Dunstan in CC.) >>> >>> I have been toying with $subject, trying to improve the ways to test

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-09 Thread Michael Paquier
On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: > On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: >> (Adding Andrew Dunstan in CC.) >> >> I have been toying with $subject, trying to improve the ways to test >> pg_upgrade across different major versions as perl

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-05-24 Thread Michael Paquier
On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: > (Adding Andrew Dunstan in CC.) > > I have been toying with $subject, trying to improve the ways to test > pg_upgrade across different major versions as perl makes that easier. > The buildfarm does three things to allow such tests

Improve TAP tests of pg_upgrade for cross-version tests

2022-05-24 Thread Michael Paquier
Hi all, (Adding Andrew Dunstan in CC.) I have been toying with $subject, trying to improve the ways to test pg_upgrade across different major versions as perl makes that easier. The buildfarm does three things to allow such tests to work (see TestUpgradeXversion.pm): - Apply a filter to the dumps