On Fri, 6 Jan 2023 at 15:33, Dean Rasheed wrote:
>
> On Fri, 6 Jan 2023 at 02:38, vignesh C wrote:
> >
> > On Thu, 5 Jan 2023 at 18:22, Dean Rasheed wrote:
> > >
> > > That leads to the attached, which barring objections, I'll push shortly.
> >
> > The changes look good to me.
> >
>
> Pushed.
On Thu, 5 Jan 2023 at 12:52, Dean Rasheed wrote:
>
> While playing around with this, I noticed that the "... SET SCHEMA"
> case offers "FROM CURRENT" and "TO" as completions, which is
> incorrect. It should really offer to complete with a list of schemas.
> However, since that's a pre-existing
On Fri, 6 Jan 2023 at 02:38, vignesh C wrote:
>
> On Thu, 5 Jan 2023 at 18:22, Dean Rasheed wrote:
> >
> > That leads to the attached, which barring objections, I'll push shortly.
>
> The changes look good to me.
>
Pushed.
Regards,
Dean
On Thu, 5 Jan 2023 at 18:22, Dean Rasheed wrote:
>
> On Tue, 6 Dec 2022 at 19:12, vignesh C wrote:
> >
> > On Tue, 6 Dec 2022 at 20:42, Melih Mutlu wrote:
> > >
> > > Also one little suggestion:
> > >
> > >> + if (ends_with(prev_wd, ')'))
> > >> + COMPLETE_WITH(Alter_routine_options, "CALLED ON
On Tue, 6 Dec 2022 at 19:12, vignesh C wrote:
>
> On Tue, 6 Dec 2022 at 20:42, Melih Mutlu wrote:
> >
> > Also one little suggestion:
> >
> >> + if (ends_with(prev_wd, ')'))
> >> + COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
> >> + "RETURNS NULL ON NULL INPUT", "STRICT",
Hi,
vignesh C , 6 Ara 2022 Sal, 22:12 tarihinde şunu yazdı:
> I did not make it as a macro for alter function options as it is used
> only in one place whereas the others were required in more than one
> place.
>
Okay, makes sense.
I tested the patch and it worked for me.
Best,
--
Melih Mutlu
On Tue, 6 Dec 2022 at 20:42, Melih Mutlu wrote:
>
> Hi Vignesh,
>
> Looks like the patch needs a rebase.
Rebased
> Also one little suggestion:
>
>> + if (ends_with(prev_wd, ')'))
>> + COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
>> + "RETURNS NULL ON NULL INPUT", "STRICT",
Hi Vignesh,
Looks like the patch needs a rebase.
Also one little suggestion:
+ if (ends_with(prev_wd, ')'))
> + COMPLETE_WITH(Alter_routine_options, "CALLED ON NULL INPUT",
> + "RETURNS NULL ON NULL INPUT", "STRICT", "SUPPORT");
What do you think about gathering FUNCTION options as you did
On Tue, 22 Nov 2022 at 05:59, Michael Paquier wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROUTINE with a
> difference
On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> Those also should be handled, attached v2 version includes the changes
> for the same.
The basic options supported by PROCEDURE are a subset of ROUTINE with a
difference of COST, IMMUTABLE, [NOT] LEAKPROOF, ROWS, STABLE
and VOLATILE.
On Fri, 28 Oct 2022 at 08:02, Dong Wook Lee wrote:
>
> On Fri, Oct 28, 2022 at 12:08 AM vignesh C wrote:
> >
> > Hi,
> >
> > Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
> > missing, this patch adds the tab completion for the same.
> >
> > Regards,
> > Vignesh
>
> Hi,
> I
On Fri, Oct 28, 2022 at 12:08 AM vignesh C wrote:
>
> Hi,
>
> Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
> missing, this patch adds the tab completion for the same.
>
> Regards,
> Vignesh
Hi,
I applied your patch and did some tests.
Is it okay not to consider SET and RESET
Hi,
Tab completion for ALTER FUNCTION/PROCEDURE/ROUTINE action was
missing, this patch adds the tab completion for the same.
Regards,
Vignesh
From 4b0473799a0d6af126ccd3d7802e5d0cbb83b944 Mon Sep 17 00:00:00 2001
From: "vignesh.c"
Date: Thu, 27 Oct 2022 14:00:46 +0530
Subject: [PATCH v1] Tab
13 matches
Mail list logo
