Re: Improve tab completion for various SET/RESET forms

2025-08-08 Thread Dagfinn Ilmari Mannsåker
Shinya Kato writes: > On Fri, Aug 1, 2025 at 2:16 AM Dagfinn Ilmari Mannsåker > wrote: >> >> Dagfinn Ilmari Mannsåker writes: >> >> > I just noticed that in addition to ALTER ROLE ... RESET being buggy, the >> > ALTER DATABASE ... RESET query doesn't schema-qualify the unnest() call. >> > Here'

Re: Improve tab completion for various SET/RESET forms

2025-08-08 Thread Kirill Reshke
Hi! On Fri, 8 Aug 2025 at 08:04, Shinya Kato wrote: > In addition to SET SCHEMA, I think you should add tab completion for > SET WITHOUT OIDS. This is unsupported since v12 [1] [1] https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-DESC-SET-WITHOUT-OIDS -- Best regar

Re: Improve tab completion for various SET/RESET forms

2025-08-07 Thread Shinya Kato
On Fri, Aug 1, 2025 at 2:16 AM Dagfinn Ilmari Mannsåker wrote: > > Dagfinn Ilmari Mannsåker writes: > > > I just noticed that in addition to ALTER ROLE ... RESET being buggy, the > > ALTER DATABASE ... RESET query doesn't schema-qualify the unnest() call. > > Here's an updated patch series that f

Re: Improve tab completion for various SET/RESET forms

2025-07-31 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > I just noticed that in addition to ALTER ROLE ... RESET being buggy, the > ALTER DATABASE ... RESET query doesn't schema-qualify the unnest() call. > Here's an updated patch series that fixes that too. The first two are > bug fixes to features new in 18 and sho

Re: Improve tab completion for various SET/RESET forms

2025-06-12 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Peter Eisentraut writes: > >> On 09.06.25 22:27, Dagfinn Ilmari Mannsåker wrote: >>> I noticed that psql tab-completes every possible session-settable >>> variable after RESET, not just the ones that have actually been set in >>> the current session. However,

Re: Improve tab completion for various SET/RESET forms

2025-06-11 Thread Dagfinn Ilmari Mannsåker
Peter Eisentraut writes: > On 09.06.25 22:27, Dagfinn Ilmari Mannsåker wrote: >> I noticed that psql tab-completes every possible session-settable >> variable after RESET, not just the ones that have actually been set in >> the current session. However, as I was fixing that I noticed several >>

Re: Improve tab completion for various SET/RESET forms

2025-06-11 Thread Peter Eisentraut
On 09.06.25 22:27, Dagfinn Ilmari Mannsåker wrote: I noticed that psql tab-completes every possible session-settable variable after RESET, not just the ones that have actually been set in the current session. However, as I was fixing that I noticed several other deficiencies around other forms o

Re: Improve tab completion for various SET/RESET forms

2025-06-09 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Hi hackers, > > I noticed that psql tab-completes every possible session-settable > variable after RESET, not just the ones that have actually been set in > the current session. However, as I was fixing that I noticed several > other deficiencies around other f

Improve tab completion for various SET/RESET forms

2025-06-09 Thread Dagfinn Ilmari Mannsåker
Hi hackers, I noticed that psql tab-completes every possible session-settable variable after RESET, not just the ones that have actually been set in the current session. However, as I was fixing that I noticed several other deficiencies around other forms of SET/RESET. So, here's the resulting y