On 2024/10/02 1:50, Nitin Jadhav wrote:
Before committing the patch, I revised it with the following changes:
- I added "shared" to the description of pg_stat_checkpointer.buffers_written
to clarify that it tracks shared buffers.
- In the checkpoint log message, I replaced "slru" with "SLR
> Before committing the patch, I revised it with the following changes:
>
> - I added "shared" to the description of pg_stat_checkpointer.buffers_written
> to clarify that it tracks shared buffers.
> - In the checkpoint log message, I replaced "slru" with "SLRU" for
> consistency,
> as upperca
On 2024/10/01 3:33, Fujii Masao wrote:
On 2024/09/22 20:44, Nitin Jadhav wrote:
+
CheckpointStats.ckpt_slru_written,
+ (double)
CheckpointStats.ckpt_slru_written * 100 / NBuffers,
I don't think NBu
On 2024/09/22 20:44, Nitin Jadhav wrote:
+
CheckpointStats.ckpt_slru_written,
+ (double)
CheckpointStats.ckpt_slru_written * 100 / NBuffers,
I don't think NBuffers represents the maximum number of SL
Thanks for the review.
> In pgstat_checkpointer.c, it looks like you missed adding
> CHECKPOINTER_COMP(slru_written) in pgstat_checkpointer_snapshot_cb().
Fixed it.
> +
> +
> +slru_written bigint
> +
> +
> +Number of SLRU buffers written during checkpoints
On 2024/07/18 16:08, Nitin Jadhav wrote:
I apologize for not being active on this thread. However, I have now
returned to the thread and confirmed that the inconsistency is still
present in the latest code. I believe it’s crucial to address this
issue, and I am currently submitting the v5 vers
; marked the patch as returned with feedback for now, so feel free to
> resubmit if you can get a new version of the patch.
> --
> Michael
From f17300193ab350c20100c8101bc2ca5f74b5c109 Mon Sep 17 00:00:00 2001
From: Nitin Jadhav
Date: Tue, 16 Jul 2024 08:32:00 +0000
Subject: [PATCH] Fix
On Sat, Jan 20, 2024 at 08:10:03AM +0530, vignesh C wrote:
> The patch does not apply anymore, please post a rebased version of the patch :
There is more to it. Some of the columns of pg_stat_bgwriter have
been moved to a different view, aka pg_stat_checkpointer. I have
marked the patch as retur
On Sun, 19 Feb 2023 at 15:28, Nitin Jadhav
wrote:
>
> > This doesn't pass the tests, because the regression tests weren't adjusted:
> > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
>
> Thanks for sharing this. I have fixed this
On Sun, 19 Feb 2023 at 04:58, Nitin Jadhav
wrote:
>
> > This doesn't pass the tests, because the regression tests weren't adjusted:
> > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
>
> Thanks for sharing this. I have fixed this
> This doesn't pass the tests, because the regression tests weren't adjusted:
> https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
Thanks for sharing this. I have fixed this in the patch attached.
>> IMO, there's no need for 2 separ
On 2022-12-21 17:14:12 +0530, Nitin Jadhav wrote:
> Kindly review and share your comments.
This doesn't pass the tests, because the regression tests weren't adjusted:
https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
> IMO, there's no need for 2 separate patches for these changes.
I will make it a single patch while sharing the next patch.
> +(errmsg("restartpoint complete: wrote %d buffers (%.1f%%), "
> +"wrote %d slru buffers (%.1f%%); %d WAL
> file(s) added, "
> +
On Wed, Dec 21, 2022 at 5:15 PM Nitin Jadhav
wrote:
>
> I have modified the code accordingly and attached the new version of
> patches. patch 0001 fixes the inconsistency in checkpointer stats and
> patch 0002 separates main buffer and SLRU buffer count from checkpoint
> complete log message.
IMO
At Wed, 21 Dec 2022 17:14:12 +0530, Nitin Jadhav
wrote in
> [1]:
> 2022-12-21 10:52:25.931 UTC [63530] LOG: checkpoint complete: wrote
> 4670 buffers (28.5%), wrote 3 slru buffers (0.0%); 0 WAL file(s)
> added, 0 removed, 4 recycled; write=0.045 s, sync=0.161 s, total=0.244
> s; sync files=25,
At Mon, 19 Dec 2022 18:05:38 +0530, Bharath Rupireddy
wrote in
> On Fri, Dec 16, 2022 at 2:14 PM Kyotaro Horiguchi
> wrote:
> >
> > In the first place I don't like that we count the same things twice.
> > Couldn't we count the number only by any one of them?
> >
> > If we remove CheckPointerSta
Thanks Robert and Andres for sharing your thoughts.
I have modified the code accordingly and attached the new version of
patches. patch 0001 fixes the inconsistency in checkpointer stats and
patch 0002 separates main buffer and SLRU buffer count from checkpoint
complete log message. In 0001, I add
On Tue, Dec 20, 2022 at 11:08 PM Andres Freund wrote:
>
> On 2022-12-20 08:18:36 -0500, Robert Haas wrote:
> > I think that the SLRU information is potentially useful, but mixing it
> > with the information about regular buffers just seems confusing.
>
> +1
>
> At least for now, it'd be different
On 2022-12-20 08:18:36 -0500, Robert Haas wrote:
> I think that the SLRU information is potentially useful, but mixing it
> with the information about regular buffers just seems confusing.
+1
At least for now, it'd be different if/when we manage to move SLRUs to
the main buffer pool.
- Andres
On Tue, Dec 20, 2022 at 8:03 AM Nitin Jadhav
wrote:
> Thanks Robert for sharing your thoughts.
> My first thought was to just remove counting SLRU buffers, then after
> some more analysis, I found that the checkpointer is responsible for
> including both regular data buffers and SLRU buffers.
I k
> Presumably we could make this consistent either by counting SLRU
> writes in both places, or by counting them in neither place. This
> proposal would count them in both places. But why is that the right
> thing to do?
>
> I'm somewhat inclined to think that we should use "buffers" to mean
> regul
On Wed, Dec 14, 2022 at 2:32 AM Nitin Jadhav
wrote:
> In order to fix this, the
> PendingCheckpointerStats.buf_written_checkpoints should be incremented
> in SlruInternalWritePage() similar to
> CheckpointStats.ckpt_bufs_written. I have attached the patch for the
> same. Please share your thoughts
On Fri, Dec 16, 2022 at 2:14 PM Kyotaro Horiguchi
wrote:
>
> In the first place I don't like that we count the same things twice.
> Couldn't we count the number only by any one of them?
>
> If we remove CheckPointerStats.ckpt_bufs_written, CreateCheckPoint can
> get the final number as the differe
At Wed, 14 Dec 2022 16:54:53 +0530, Bharath Rupireddy
wrote in
> Indeed PendingCheckpointerStats.buf_written_checkpoints needs to count
> buffer writes in SlruInternalWritePage(). However, does it need to be
> done immediately there? The stats will not be visible to the users
> until the next pg
> /* If part of a checkpoint, count this as a buffer written. */
>if (fdata)
>CheckpointStats.ckpt_bufs_written++;
> + PendingCheckpointerStats.buf_written_checkpoints++;
> Also, the proposed patch would touch PendingCheckpointerStats even
> when there is no fdata, aka outside th
> Indeed PendingCheckpointerStats.buf_written_checkpoints needs to count
> buffer writes in SlruInternalWritePage(). However, does it need to be
> done immediately there? The stats will not be visible to the users
> until the next pgstat_report_checkpointer(). Incrementing
> buf_written_checkpoints
On Wed, Dec 14, 2022 at 04:54:53PM +0530, Bharath Rupireddy wrote:
> Indeed PendingCheckpointerStats.buf_written_checkpoints needs to count
> buffer writes in SlruInternalWritePage(). However, does it need to be
> done immediately there? The stats will not be visible to the users
> until the next p
On Wed, Dec 14, 2022 at 1:02 PM Nitin Jadhav
wrote:
>
> Hi,
>
> While working on checkpoint related stuff, I have encountered that
> there is some inconsistency while reporting checkpointer stats. When a
> checkpoint gets completed, a checkpoint complete message gets logged.
> This message has a l
Hi,
While working on checkpoint related stuff, I have encountered that
there is some inconsistency while reporting checkpointer stats. When a
checkpoint gets completed, a checkpoint complete message gets logged.
This message has a lot of information including the buffers written
(CheckpointStats.c
29 matches
Mail list logo
