Thank you for looking this.
At Tue, 19 Mar 2024 10:50:23 +0100, Peter Eisentraut
wrote in
> On 15.03.24 08:20, Kyotaro Horiguchi wrote:
> > diff --git a/src/backend/access/transam/twophase.c
> > b/src/backend/access/transam/twophase.c
> > @@ -1369,8 +1369,8 @@ ReadTwoPhaseFile(TransactionId xid
On 15.03.24 08:20, Kyotaro Horiguchi wrote:
diff --git a/src/backend/access/transam/twophase.c
b/src/backend/access/transam/twophase.c
@@ -1369,8 +1369,8 @@ ReadTwoPhaseFile(TransactionId xid, bool missing_ok)
errmsg("could not read file \"%s\":
%m", pat
At Fri, 15 Mar 2024 16:20:27 +0900 (JST), Kyotaro Horiguchi
wrote in
> I checked for that kind of msgids in a bit more intensive way. The
> numbers are the line numbers in ja.po of backend. I didn't check the
> same for other modules.
>
> > ###: invalid timeline %lld
> >@ backup/walsumm
At Fri, 15 Mar 2024 16:01:28 +1300, David Rowley wrote
in
> On Fri, 15 Mar 2024 at 15:27, Kyotaro Horiguchi
> wrote:
> > I have considered only the two messages. Actually, buffile.c and md.c
> > are already like that. The attached aligns the messages in
> > pg_combinebackup.c and reconstruct.c
On Fri, 15 Mar 2024 at 15:27, Kyotaro Horiguchi wrote:
> I have considered only the two messages. Actually, buffile.c and md.c
> are already like that. The attached aligns the messages in
> pg_combinebackup.c and reconstruct.c with the precedents.
This looks like a worthy cause to make translator
Thank you for the suggestions.
At Thu, 14 Mar 2024 13:45:41 +0100, Daniel Gustafsson wrote
in
> I've only skimmed this so far but +1 on keeping the messages the same where
> possible to reduce translation work. Adding a comment on the message where
> the
> casting is done to indicate that it
On 14.03.24 05:20, Kyotaro Horiguchi wrote:
A recent commit 6612185883 introduced two error messages that are
identical in text but differ in their placeholders.
- pg_fatal("could not read file \"%s\": read only %d of %d
bytes",
-fil
> On 14 Mar 2024, at 05:20, Kyotaro Horiguchi wrote:
> I'd be happy if the two messages kept consistency. I suggest aligning
> types instead of making the messages different, as attached.
I've only skimmed this so far but +1 on keeping the messages the same where
possible to reduce translation w
Hello.
A recent commit 6612185883 introduced two error messages that are
identical in text but differ in their placeholders.
- pg_fatal("could not read file \"%s\": read only %d of
%d bytes",
-filename, (int) rb, (int) st.st_size);
+
