Re: MSVC SSL test failure

2021-12-07 Thread Andrew Dunstan
On 12/7/21 13:22, Tom Lane wrote: > Alexander Lakhin writes: >> 07.12.2021 19:25, Tom Lane wrote: >>> Hmm. I wonder whether using SD_BOTH behaves any differently. >> With shutdown(MyProcPort->sock, SD_BOTH) the test failed for me on >> iterations 1, 2, 3, 16 (just as without shutdown() at

Re: MSVC SSL test failure

2021-12-07 Thread Tom Lane
Alexander Lakhin writes: > 07.12.2021 19:25, Tom Lane wrote: >> Hmm. I wonder whether using SD_BOTH behaves any differently. > With shutdown(MyProcPort->sock, SD_BOTH) the test failed for me on > iterations 1, 2, 3, 16 (just as without shutdown() at all). > So shutdown with the SD_SEND flag

Re: MSVC SSL test failure

2021-12-07 Thread Alexander Lakhin
Hello Tom, 07.12.2021 19:25, Tom Lane wrote: > Hmm. I wonder whether using SD_BOTH behaves any differently. With shutdown(MyProcPort->sock, SD_BOTH) the test failed for me on iterations 1, 2, 3, 16 (just as without shutdown() at all). So shutdown with the SD_SEND flag definitely behaves much

Re: MSVC SSL test failure

2021-12-07 Thread Tom Lane
Alexander Lakhin writes: > It seems that the test failure rate may depend on the specs/environment. No surprise there, since the issue is almost surely timing-dependent. > shutdown(MyProcPort->sock, SD_SEND) apparently fixes the issue, I've got > 83 successful runs, but then iteration 84

Re: MSVC SSL test failure

2021-12-06 Thread Alexander Lakhin
06.12.2021 23:51, Andrew Dunstan wrote: > I have been getting 100% failures on the SSL tests with closesocket() > alone, and 100% success over 10 tests with this: > > > diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c > index 96ab37c7d0..5998c089b0 100644 > ---

Re: MSVC SSL test failure

2021-12-06 Thread Andrew Dunstan
On 12/6/21 10:30, Alexander Lakhin wrote: > Hello Andrew, > 06.12.2021 17:56, Andrew Dunstan wrote: >> Yeah, quite annoying, especially because only some combinations of MSVC >> runtime / openssl version seem to trigger the problem. >> >> >> Adding a shutdown() before the closesocket() also

Re: MSVC SSL test failure

2021-12-06 Thread Alexander Lakhin
Hello Andrew, 06.12.2021 17:56, Andrew Dunstan wrote: > Yeah, quite annoying, especially because only some combinations of MSVC > runtime / openssl version seem to trigger the problem. > > > Adding a shutdown() before the closesocket() also fixes the issue. > Can you confirm that adding

Re: MSVC SSL test failure

2021-12-06 Thread Daniel Gustafsson
> On 6 Dec 2021, at 15:56, Andrew Dunstan wrote: > Yeah, quite annoying, especially because only some combinations of MSVC > runtime / openssl version seem to trigger the problem. > > Adding a shutdown() before the closesocket() also fixes the issue. If you have a patch you're testing I'm

Re: MSVC SSL test failure

2021-12-06 Thread Andrew Dunstan
On 12/6/21 01:02, Tom Lane wrote: > Andrew Dunstan writes: >> On 12/5/21 12:50, Tom Lane wrote: >>> This looks quite a bit like the sort of failure that commit >>> 6051857fc was meant to forestall. I wonder whether reverting >>> that commit changes the results? You might also try inserting

Re: MSVC SSL test failure

2021-12-06 Thread Daniel Gustafsson
> On 6 Dec 2021, at 07:02, Tom Lane wrote: > > Andrew Dunstan writes: >> On 12/5/21 12:50, Tom Lane wrote: >>> This looks quite a bit like the sort of failure that commit >>> 6051857fc was meant to forestall. I wonder whether reverting >>> that commit changes the results? You might also try

Re: MSVC SSL test failure

2021-12-05 Thread Tom Lane
Andrew Dunstan writes: > On 12/5/21 12:50, Tom Lane wrote: >> This looks quite a bit like the sort of failure that commit >> 6051857fc was meant to forestall. I wonder whether reverting >> that commit changes the results? You might also try inserting >> a shutdown() call, as we'd decided not to

Re: MSVC SSL test failure

2021-12-05 Thread Andrew Dunstan
On 12/5/21 12:50, Tom Lane wrote: > Andrew Dunstan writes: >> I am getting this test failure 001_ssltests.pl on my test MSVC system >> when SSL tests are enabled: >> not ok 110 - certificate authorization fails with revoked client cert >> with server-side CRL directory: matches >> #

Re: MSVC SSL test failure

2021-12-05 Thread Daniel Gustafsson
> On 5 Dec 2021, at 23:44, Andrew Dunstan wrote: > Can you show me the cirrus.yml file you're using to test with? I used the 0001 patch from this thread: https://www.postgresql.org/message-id/20211101055720.7mzwtkhzxmorpxth%40alap3.anarazel.de > A URL ref to the results would also help. I

Re: MSVC SSL test failure

2021-12-05 Thread Andrew Dunstan
On 12/5/21 15:14, Daniel Gustafsson wrote: >> On 5 Dec 2021, at 18:03, Andrew Dunstan wrote: >> I am getting this test failure 001_ssltests.pl on my test MSVC system >> when SSL tests are enabled: >> >>not ok 110 - certificate authorization fails with revoked client cert >> with

Re: MSVC SSL test failure

2021-12-05 Thread Daniel Gustafsson
> On 5 Dec 2021, at 18:03, Andrew Dunstan wrote: > I am getting this test failure 001_ssltests.pl on my test MSVC system > when SSL tests are enabled: > >not ok 110 - certificate authorization fails with revoked client cert with > server-side CRL directory: matches > ># Failed test

Re: MSVC SSL test failure

2021-12-05 Thread Tom Lane
Andrew Dunstan writes: > I am getting this test failure 001_ssltests.pl on my test MSVC system > when SSL tests are enabled: > not ok 110 - certificate authorization fails with revoked client cert > with server-side CRL directory: matches > # Failed test 'certificate authorization

MSVC SSL test failure

2021-12-05 Thread Andrew Dunstan
I am getting this test failure 001_ssltests.pl on my test MSVC system when SSL tests are enabled: not ok 110 - certificate authorization fails with revoked client cert with server-side CRL directory: matches # Failed test 'certificate authorization fails with revoked client cert