Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
В Wed, 28 Feb 2018 10:45:24 +0900 Michael Paquier пишет: > Replace backslashes by forward slashes in MSVC build code > > This makes it possible to run some stages of these build scripts on > non-Windows systems. That way, we can more easily test whether file > moves or makefile changes might b

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Michael Paquier
On Tue, Feb 27, 2018 at 04:14:02PM +0300, Victor Wagner wrote: > How interesting - somewhere between 9.3 (for which patch was made) and > 9.5 path to the Makefile in windows-specific script was changed from > Windows-style separators to unix-style and this broke context. You are looking for that,

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Noah Misch
On Tue, Feb 27, 2018 at 11:43:34AM +0100, Magnus Hagander wrote: > On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner wrote: > > These errors seems to be caused by commit 91f3ffc5249 > > which improves readability of src/bin/scripts/Makefile for > > humans by moving list of common object files into

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
On Tue, 27 Feb 2018 14:14:04 +0100 Magnus Hagander wrote: > > Thanks. I've pushed this for 9.3-9.5. > > Please verify that it looks good if you can (it takes a while for the > buildfarm to get around to it) Works at least for 9.5, although I haven't run tap tests on this build. ---

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Magnus Hagander
On Tue, Feb 27, 2018 at 2:05 PM, Victor Wagner wrote: > On Tue, 27 Feb 2018 13:35:33 +0100 > Magnus Hagander wrote: > > > > > Note that said commit (91f3ffc5249) is not limited to rearranging > > > makefile. It also changes a lot into C code itself. So it is not a > > > question of reverting com

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
On Tue, 27 Feb 2018 13:49:29 +0100 Magnus Hagander wrote: > Does not apply cleanly to 9.5 at least for me. Probably easy to fix, > but I still feel we shouldn't mess around with the buildsystem in > back branches unless we actually have to. How interesting - somewhere between 9.3 (for which

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Sandeep Thakkar
Hi Magnus On Tue, Feb 27, 2018 at 6:05 PM, Magnus Hagander wrote: > On Tue, Feb 27, 2018 at 11:53 AM, Victor Wagner > wrote: > >> On Tue, 27 Feb 2018 11:43:34 +0100 >> Magnus Hagander wrote: >> >> > On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner >> > wrote: >> > >> > > Hello, hackers. >> > >

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
On Tue, 27 Feb 2018 13:35:33 +0100 Magnus Hagander wrote: > > Note that said commit (91f3ffc5249) is not limited to rearranging > > makefile. It also changes a lot into C code itself. So it is not a > > question of reverting commit - it is making new commit, which > > reverts changes in just one

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Magnus Hagander
On Tue, Feb 27, 2018 at 1:42 PM, Victor Wagner wrote: > On Tue, 27 Feb 2018 11:43:34 +0100 > Magnus Hagander wrote: > > > > I'm unsure why this was introduced in 9.5 and earlier, but not in the > > newer ones. This smells like a possible backpatch mistake, in which > > case that part should pro

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
On Tue, 27 Feb 2018 11:43:34 +0100 Magnus Hagander wrote: > I'm unsure why this was introduced in 9.5 and earlier, but not in the > newer ones. This smells like a possible backpatch mistake, in which > case that part should probably be backed out of the old branches > rather than teaching mkvcb

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Magnus Hagander
On Tue, Feb 27, 2018 at 11:53 AM, Victor Wagner wrote: > On Tue, 27 Feb 2018 11:43:34 +0100 > Magnus Hagander wrote: > > > On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner > > wrote: > > > > > Hello, hackers. > > > > > > I've tried to build last state of REL9_5_STABLE branch (commit > > > 1f19e4

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
On Tue, 27 Feb 2018 11:43:34 +0100 Magnus Hagander wrote: > On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner > wrote: > > > Hello, hackers. > > > > I've tried to build last state of REL9_5_STABLE branch (commit > > 1f19e46124eee8c6a54834) and under Win32 encountered following > > errors: > > [s

Re: MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Magnus Hagander
On Tue, Feb 27, 2018 at 11:27 AM, Victor Wagner wrote: > Hello, hackers. > > I've tried to build last state of REL9_5_STABLE branch (commit > 1f19e46124eee8c6a54834) and under Win32 encountered following errors: > > > C:\Program Files (x86)\Microsoft Visual Studio > 12.0\VC\bin\amd64\link.exe

MSVC builld of 9.5.12 is broken?

2018-02-27 Thread Victor Wagner
Hello, hackers. I've tried to build last state of REL9_5_STABLE branch (commit 1f19e46124eee8c6a54834) and under Win32 encountered following errors: C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64\link.exe /ERRORREPORT:QUEUE /OUT:".\Release\createdb\createdb.exe" /INCREMENT