Re: Make drop database safer

2019-03-06 Thread Ashwin Agrawal
On Wed, Mar 6, 2019 at 7:56 AM Tomas Vondra wrote: > > > On 2/12/19 12:55 AM, Ashwin Agrawal wrote: > > > > Thanks for the response and inputs. > > > > On Sat, Feb 9, 2019 at 4:51 AM Andres Freund > > wrote: > > > > Hi, > > > > On 2019-02-08 16:36:13 -0800, Ale

Re: Make drop database safer

2019-03-06 Thread Tomas Vondra
On 2/12/19 12:55 AM, Ashwin Agrawal wrote: Thanks for the response and inputs. On Sat, Feb 9, 2019 at 4:51 AM Andres Freund > wrote: Hi, On 2019-02-08 16:36:13 -0800, Alexandra Wang wrote: > Current sequence of operations for drop database (dropdb()

Re: Make drop database safer

2019-03-06 Thread Ashwin Agrawal
On Mon, Feb 11, 2019 at 3:55 PM Ashwin Agrawal wrote: > > Thanks for the response and inputs. > > On Sat, Feb 9, 2019 at 4:51 AM Andres Freund wrote: > >> Hi, >> >> On 2019-02-08 16:36:13 -0800, Alexandra Wang wrote: >> > Current sequence of operations for drop database (dropdb()) >> > 1. Start

Re: Make drop database safer

2019-02-11 Thread Ashwin Agrawal
Thanks for the response and inputs. On Sat, Feb 9, 2019 at 4:51 AM Andres Freund wrote: > Hi, > > On 2019-02-08 16:36:13 -0800, Alexandra Wang wrote: > > Current sequence of operations for drop database (dropdb()) > > 1. Start Transaction > > 2. Make catalog changes > > 3. Drop database buffers

Re: Make drop database safer

2019-02-09 Thread Andres Freund
Hi, On 2019-02-08 16:36:13 -0800, Alexandra Wang wrote: > Current sequence of operations for drop database (dropdb()) > 1. Start Transaction > 2. Make catalog changes > 3. Drop database buffers > 4. Forget database fsync requests > 5. Checkpoint > 6. Delete database directory > 7. Commit Transacti

Make drop database safer

2019-02-09 Thread Alexandra Wang
Current sequence of operations for drop database (dropdb()) 1. Start Transaction 2. Make catalog changes 3. Drop database buffers 4. Forget database fsync requests 5. Checkpoint 6. Delete database directory 7. Commit Transaction Problem This sequence is unsafe from couple of fronts. Like if drop d