On Thu, Dec 09, 2021 at 05:42:56PM +0900, Masahiko Sawada wrote:
> Thank you for updating the patch. The patch looks good to me.
Done this way. Please note that while testing this patch, I have
found a completely different issue. I'll spawn a thread about that in
a minute..
--
Michael
On Thu, Dec 9, 2021 at 4:02 PM Michael Paquier wrote:
>
> On Wed, Dec 08, 2021 at 05:03:30PM +0900, Masahiko Sawada wrote:
> > Agreed. I've attached an updated patch that incorporated your review
> > comments. Please review it.
>
> That looks correct to me. One thing that I have noticed while
>
l
From c821c67698535ded147e8686c182d91462a16599 Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Thu, 9 Dec 2021 16:00:53 +0900
Subject: [PATCH v3] Make pg_waldump report replication origin ID, LSN, and
timestamp.
Commit 7b8a899bdeb made pg_waldump report the detail of information
about PREPARE TRANS
On Wed, Dec 8, 2021 at 4:31 PM Michael Paquier wrote:
>
> On Mon, Dec 06, 2021 at 11:24:09PM +0900, Masahiko Sawada wrote:
> > On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier wrote:
> >> Shouldn't you check for parsed.origin_lsn instead? The replication
> >> origin is stored there as far as I
On Mon, Dec 06, 2021 at 11:24:09PM +0900, Masahiko Sawada wrote:
> On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier wrote:
>> Shouldn't you check for parsed.origin_lsn instead? The replication
>> origin is stored there as far as I read EndPrepare().
>
> Also, looking at PrepareRedoAdd(), we check
On Mon, Dec 6, 2021 at 11:24 PM Masahiko Sawada wrote:
>
> On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier wrote:
> >
> > On Mon, Dec 06, 2021 at 04:35:07PM +0900, Masahiko Sawada wrote:
> > > I've attached a patch to add replication origin information to
> > > xact_desc_prepare().
> >
> > Yeah.
On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier wrote:
>
> On Mon, Dec 06, 2021 at 04:35:07PM +0900, Masahiko Sawada wrote:
> > I've attached a patch to add replication origin information to
> > xact_desc_prepare().
>
> Yeah.
>
> + if (origin_id != InvalidRepOriginId)
> +
On Mon, Dec 06, 2021 at 04:35:07PM +0900, Masahiko Sawada wrote:
> I've attached a patch to add replication origin information to
> xact_desc_prepare().
Yeah.
+ if (origin_id != InvalidRepOriginId)
+ appendStringInfo(buf, "; origin: node %u, lsn %X/%X, at %s",
+
pg_waldump report replication origin ID, LSN, and
timestamp.
Commit 7b8a899bdeb made pg_waldump report the detail of information
about PREPARE TRANSACTION record, like global transaction
identifier. However, replication origin LSN and timestamp were not
reporeted. These are helpful when diagnosing 2PC
